Skip to content

899 add gamma distribution and other parameters to state_age_function#929

Closed
lenaploetzke wants to merge 2 commits intomainfrom
899-add-gamma-distribution-and-other-parameters-to-state_age_function
Closed

899 add gamma distribution and other parameters to state_age_function#929
lenaploetzke wants to merge 2 commits intomainfrom
899-add-gamma-distribution-and-other-parameters-to-state_age_function

Conversation

@lenaploetzke
Copy link
Member

@lenaploetzke lenaploetzke commented Feb 7, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • added the parameters location and scale to StateAgeFunction
  • added three state age functions
  • extended the boost archive of memilio (necessary for the state age functions)
  • added tests

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #899.

@lenaploetzke lenaploetzke added class::feature A feature to be implemented for some part of the software status::in progress This issue is in progess. model::ide This issue concerns any kind of integro differential equations-based model. loc::infrastructure General MEmilio Infrastructure related issues model::lct Models using the linear chain trick labels Feb 7, 2024
@lenaploetzke lenaploetzke self-assigned this Feb 7, 2024
@lenaploetzke lenaploetzke linked an issue Feb 7, 2024 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d6bb6fd) 95.88% compared to head (298e628) 95.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #929      +/-   ##
==========================================
+ Coverage   95.88%   95.91%   +0.03%     
==========================================
  Files         118      118              
  Lines        9397     9477      +80     
==========================================
+ Hits         9010     9090      +80     
  Misses        387      387              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenaploetzke lenaploetzke added status::in review This issues is in review. and removed status::in progress This issue is in progess. labels Feb 7, 2024
@lenaploetzke lenaploetzke requested a review from mknaranja March 20, 2024 12:33
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a big problem. Did you recommit a changed boost? (+46 MB?)

Copy link
Member Author

@lenaploetzke lenaploetzke Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes i did. Additional functionality of boost is used for the GammaSurvivalFunction. Should talk about this.

@lenaploetzke
Copy link
Member Author

Attention: this PR should be recreated without the new boost file in the history.

@mknaranja
Copy link
Member

@lenaploetzke Could you recreate a fresh branch and push all your changes except the boost file to the new branch and also create a new PR?

@lenaploetzke lenaploetzke removed the request for review from annawendler April 8, 2024 05:59
@lenaploetzke
Copy link
Member Author

@lenaploetzke Could you recreate a fresh branch and push all your changes except the boost file to the new branch and also create a new PR?

Yes, see comment above.

@lenaploetzke lenaploetzke added status::on hold This issue is on hold. and removed status::in review This issues is in review. class::feature A feature to be implemented for some part of the software model::ide This issue concerns any kind of integro differential equations-based model. loc::infrastructure General MEmilio Infrastructure related issues model::lct Models using the linear chain trick labels Apr 10, 2024
@lenaploetzke
Copy link
Member Author

Moved to #1004

@lenaploetzke lenaploetzke deleted the 899-add-gamma-distribution-and-other-parameters-to-state_age_function branch May 13, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status::on hold This issue is on hold.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add gamma distribution and other parameters to state_age_function

2 participants