Fix/Update NuGet Package to Include Cross Platform Capstone Binaries#32
Merged
9ee1 merged 2 commits into9ee1:masterfrom Feb 24, 2022
Merged
Fix/Update NuGet Package to Include Cross Platform Capstone Binaries#329ee1 merged 2 commits into9ee1:masterfrom
9ee1 merged 2 commits into9ee1:masterfrom
Conversation
9ee1
changed the title
Owner
|
This is great! Thank you very much for your contribution. I apologize about the delay in getting to this. I haven't been checking my GitHub notifications frequently. |
Contributor
|
@js6pak which version of Capstone have you used in this PR? I am asking because I would like to send a PR with arm64 support for Windows and wondering if I should update other dependencies as well |
Contributor
Author
|
4.0.2 which still is the latest stable version |
|
You deleted the Gee.External.Capstone.targets file which was responsible for copying the native dll to the output directory. I don't understand that: Do I not need the native dll in the output directory anymore? Is it copied with some other magic? |
Contributor
Author
Yes, it will be copied with the poorly-documented nuget magic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies packaging.
Package info was moved from .nuspec to the .csproj.
pack.batis no longer needed, .nupkg is now made after every build.Closes #27, closes #28, closes #31