Conversation
|
Hello. Thank you very much for your contribution. It looks like the v4 branch has additional commits then the 4.0.2 tag, the latter of which is marked as the latest release. I know it is mentioned in #32 the binaries were compiled for 4.0.2, but I am not sure which branch/tag on the Capstone repository they were compiled from. I have not taken a look at the diff so I am not sure it would make a difference but it might be prudent to have all the packaged binaries built from the same source. @js6pak, can you please confirm if you used the v4 branch or the 4.0.2 tag in #32? If it is the latter, @adamsitnik, would you mind rebuilding the binary in this PR from the 4.0.2 tag? |
|
My binaries were from the 4.0.2 tag not the branch, yes |
|
@9ee1 Good point! I've updated the PR and provided version built from 4.0.2 tag. Thanks! |
|
Thank you @js6pak and @adamsitnik. |
Steps I took:
capstone.dlldotnet packnuget.configfile pointing to the folder with the packagecc @janvorli