Fix updating of image tag versions #626
Conversation
|
Deployment previews on netlify for branch
|
| push: | ||
| branches: | ||
| - 'main' | ||
| tags: |
There was a problem hiding this comment.
I deleted this by accident, but I'm not sure if this is even needed in the current workflow?
There was a problem hiding this comment.
Yeah, we probably are now safely away from the "bothering to tag" workflow
| if: 1==2 | ||
| with: | ||
| path: ./repos/wbaas-deploy-staging | ||
| commit-message: 'Staging+Local: Deploy new UI image ${{ steps.docker_meta.outputs.tags }}' |
There was a problem hiding this comment.
This is a very theoretical concern, but I wonder if we want to replace the "deploy" terminology in these PRs with "update" as no automated deployment is happening, it's more of an automated update a human would then deploy.
There was a problem hiding this comment.
Yeah, I can see us looking at making this more meaningful as time goes by. Right now I think it will do
tarrow
left a comment
tarrow
left a comment
There was a problem hiding this comment.
Looks good to me; lets try this thing for a few days :)
Supersedes #623
Doing this on a new branch so I don't eat potential local changes from @rosalieper
Example PRs opened by this approach: