Skip to content

WIP: Fix the yaml edit #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rosalieper wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP: Fix the yaml edit #623

rosalieper wants to merge 1 commit into from

Conversation

@rosalieper
Copy link
Contributor

@rosalieper rosalieper commented Jan 18, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 18, 2023

Deployment previews on netlify for branch refs/pull/623/merge will be at the following locations (when build is done):

@rosalieper rosalieper force-pushed the github-action branch 2 times, most recently from 7b49b88 to 209c4db Compare January 18, 2023 17:28
@rosalieper rosalieper marked this pull request as draft January 18, 2023 17:29
@rosalieper rosalieper force-pushed the github-action branch 26 times, most recently from e22103f to fe2b088 Compare January 19, 2023 16:10
@rosalieper rosalieper force-pushed the github-action branch 2 times, most recently from bb80cf3 to b0d41dc Compare January 19, 2023 16:59
@rosalieper rosalieper requested review from m90 and tarrow January 19, 2023 16:59
@rosalieper rosalieper marked this pull request as ready for review January 19, 2023 16:59
tarrow
tarrow reviewed Jan 19, 2023
View reviewed changes
@tarrow
Copy link
Contributor

tarrow commented Jan 20, 2023

Looks like there might still be a little work to not break the null. Maybe this can help? https://stackoverflow.com/a/57207057

Also it would be good to fix the branch name; right now it's literally (e.g.) deploy-to-production- without any suffix. This means that if more than one PR is open at a timer there will be collisions.

@rosalieper rosalieper force-pushed the github-action branch 11 times, most recently from 176ce64 to 81a6a12 Compare January 21, 2023 16:36
@m90 m90 mentioned this pull request Jan 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarrow tarrow tarrow left review comments

@m90 m90 Awaiting requested review from m90

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rosalieper @tarrow