feat(telegram): expose parseMode config option#366
Closed
Koshkoshinsk wants to merge 1 commit intovercel:mainfrom
Closed
feat(telegram): expose parseMode config option#366Koshkoshinsk wants to merge 1 commit intovercel:mainfrom
Koshkoshinsk wants to merge 1 commit intovercel:mainfrom
Conversation
Since vercel#245, the Telegram adapter hardcodes parse_mode: "Markdown" whenever the caller passes { markdown: ... }. Telegram considers legacy Markdown a deprecated mode and it has no escape support, so callers can hit "Bad Request: can't parse entities" with no way to recover other than dropping the message. Add an optional parseMode field to TelegramAdapterConfig that lets callers choose between "Markdown" (default, backward compatible), "MarkdownV2", "HTML", or "none" (omit parse_mode entirely as a safety valve). The converter is unchanged; this PR only exposes a knob so callers whose upstream renderer produces MarkdownV2/HTML/plain-text can tell the adapter not to ask Telegram to parse legacy Markdown entities.
Contributor
|
@Koshkoshinsk is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Closing — going to handle this on our caller side instead, no upstream change needed for now. |
Author
|
Reopening — apologies for the churn, the close was unintended on my end. Branch restored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since #245, the Telegram adapter hardcodes
parse_mode: "Markdown"whenever the caller passes{ markdown: ... }. Telegram considers legacyMarkdowna deprecated mode (see Bot API formatting options) and it has no escape support, so callers can hitBad Request: can't parse entitieswith no way to recover other than dropping the message permanently.For example, an agent reply containing routine markdown like:
is rejected by Telegram, and there is currently no way for the caller to pick a different parse mode or disable parsing entirely.
Change
Adds an optional
parseModefield toTelegramAdapterConfig:"Markdown"— fully backward compatible with fix(telegram): set parse_mode for markdown messages #245."MarkdownV2"/"HTML"are passed through to Telegram unchanged."none"omitsparse_mode, sending content as plain text (useful as a safety valve).The markdown converter is unchanged; this PR only exposes a knob. Callers whose upstream renderer produces MarkdownV2/HTML/plain-text can now tell the adapter not to ask Telegram to parse legacy Markdown entities.
Tests
parseMode: "MarkdownV2"and"HTML"round-trip into the request body.parseMode: "none"omitsparse_modeentirely.parseModevalue throwsValidationErrorfrom the constructor.pnpm turbo build --filter @chat-adapter/telegramandpnpm vitest run(105 tests) both clean.