fix(telegram): set parse_mode for markdown messages#245
Merged
haydenbleasel merged 2 commits intomainfrom Mar 16, 2026
Merged
Conversation
postMessage and editMessage only set parse_mode when a card was present, causing markdown messages to render as plain text with visible formatting characters. Now also sets parse_mode when the message has a markdown field. Closes #226
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…editMessage Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
haydenbleasel
left a comment
haydenbleasel
left a comment
There was a problem hiding this comment.
Done! Extracted a resolveParseMode helper that both postMessage and editMessage now use. Thanks for the catch! 🙌
Koshkoshinsk
added a commit
to Koshkoshinsk/chat
that referenced
this pull request
Apr 12, 2026
Since vercel#245, the Telegram adapter hardcodes parse_mode: "Markdown" whenever the caller passes { markdown: ... }. Telegram considers legacy Markdown a deprecated mode and it has no escape support, so callers can hit "Bad Request: can't parse entities" with no way to recover other than dropping the message. Add an optional parseMode field to TelegramAdapterConfig that lets callers choose between "Markdown" (default, backward compatible), "MarkdownV2", "HTML", or "none" (omit parse_mode entirely as a safety valve). The converter is unchanged; this PR only exposes a knob so callers whose upstream renderer produces MarkdownV2/HTML/plain-text can tell the adapter not to ask Telegram to parse legacy Markdown entities.
Koshkoshinsk
added a commit
to Koshkoshinsk/chat
that referenced
this pull request
Apr 12, 2026
Since vercel#245, the Telegram adapter hardcodes parse_mode: "Markdown" whenever the caller passes { markdown: ... }. Telegram considers legacy Markdown a deprecated mode and it has no escape support, so callers can hit "Bad Request: can't parse entities" with no way to recover other than dropping the message. Add an optional parseMode field to TelegramAdapterConfig that lets callers choose between "Markdown" (default, backward compatible), "MarkdownV2", "HTML", or "none" (omit parse_mode entirely as a safety valve). The converter is unchanged; this PR only exposes a knob so callers whose upstream renderer produces MarkdownV2/HTML/plain-text can tell the adapter not to ask Telegram to parse legacy Markdown entities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
postMessageandeditMessageonly setparse_modewhen a card was present, causing{ markdown: "..." }messages to render as plain text with visible formatting characters. Now also setsparse_modeto"Markdown"when the message has amarkdownfield.Closes #226