Skip to content

fix standalone activity routes and prep for release#3168

Merged
rossedfort merged 4 commits intomainfrom
standalone-activities-route-fix
Feb 19, 2026
Merged

fix standalone activity routes and prep for release#3168
rossedfort merged 4 commits intomainfrom
standalone-activities-route-fix

Conversation

@rossedfort
Copy link
Copy Markdown
Contributor

@rossedfort rossedfort commented Feb 19, 2026

Description & motivation 💭

  • move Activity Details route from src/routes/(app)/namespaces/[namespace]/activities/[activityId] to src/routes/(app)/namespaces/[namespace]/activities/[activityId]/[runId] and adjust links from List and Create pages.
  • Add a minimumVersionRequired check for server version 1.30.0 for nav link and guard.
  • make sure route ID is passed in initial call to DescribeActivityExecution

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@rossedfort rossedfort requested review from a team and Alex-Tideman as code owners February 19, 2026 18:27
@vercel
Copy link
Copy Markdown

vercel bot commented Feb 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Feb 19, 2026 6:34pm

Request Review

@@ -140,7 +140,7 @@
if (!form.valid) return;

try {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Argument of type '{ searchAttributes: SearchAttributeInput[]; input: string; messageType: string; scheduleToStartTimeout: string; summary: string; details: string; heartbeatTimeout: string; ... 13 more ...; scheduleToCloseTimeout: string; }' is not assignable to parameter of type 'StandaloneActivityFormData'.

this.activityId,
this.runId,
);
} catch (error) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Argument of type 'unknown' is not assignable to parameter of type 'Error'.

@@ -48,7 +51,6 @@ export class StandaloneActivityPoller {
this.onUpdate(activityExecution);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ 'activityExecution' is possibly 'undefined'.

@@ -48,7 +51,6 @@ export class StandaloneActivityPoller {
this.onUpdate(activityExecution);

if (activityExecution.info.status === 'ACTIVITY_EXECUTION_STATUS_RUNNING') {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ 'activityExecution' is possibly 'undefined'.
  • ⚠️ Type 'string | undefined' is not assignable to type 'string'.

@temporal-cicd
Copy link
Copy Markdown
Contributor

temporal-cicd bot commented Feb 19, 2026

Warnings
⚠️

📊 Strict Mode: 21 errors in 6 files (1.9% of 1119 total)

src/lib/utilities/route-for.ts (1)
  • L283:4: Type 'string | undefined' is not assignable to type 'string'.
src/lib/services/standalone-activities.ts (5)
  • L59:6: Type 'ErrorCallback' is not assignable to type '(error: unknown, toasts?: Toaster, errors?: Writable<NetworkError | null>, isBrowser?: boolean) => void'.
  • L123:6: Type '{ indexedFields?: ({ [k: string]: temporal.api.common.v1.IPayload; } | null); }' is not assignable to type '{ [k: string]: IPayload; }'.
  • L124:31: Argument of type 'SearchAttributeInput[]' is not assignable to parameter of type '{ type: "Unspecified" | "Keyword" | "Text" | "Int" | "Double" | "Bool" | "KeywordList" | "Datetime"; label: string; value?: any; }[]'.
  • L137:4: Type 'ISearchAttributes | null' is not assignable to type 'ISearchAttributes | undefined'.
  • L151:4: Type '{ backoffCoefficient?: number | undefined; maximumAttempts?: number | undefined; maximumInterval?: string | undefined; initialInterval?: string | undefined; }' is not assignable to type 'RetryPolicy'.
src/lib/utilities/standalone-activity-poller.svelte.ts (8)
  • L18:10: Property 'token' has no initializer and is not definitely assigned in the constructor.
  • L47:19: Argument of type 'unknown' is not assignable to parameter of type 'Error'.
  • L50:18: Argument of type 'ActivityExecution | undefined' is not assignable to parameter of type 'ActivityExecution'.
  • L52:8: 'activityExecution' is possibly 'undefined'.
  • L53:6: Type 'string | undefined' is not assignable to type 'string'.
  • L53:19: 'activityExecution' is possibly 'undefined'.
  • L69:12: Type 'string | undefined' is not assignable to type 'string'.
  • L77:23: Argument of type 'unknown' is not assignable to parameter of type 'Error'.
src/lib/components/standalone-activities/start-standalone-activity-form/form.svelte (5)
  • L137:6: Type 'ClientValidationAdapter<{ namespace: string; identity: string; activityId: string; taskQueue: string; activityType: string; summary?: string | undefined; details?: string | undefined; input?: string | undefined; ... 11 more ...; idConflictPolicy?: string | undefined; }, { ...; }>' is not assignable to type 'ClientValidationAdapter<Partial<{ input: string; messageType: string; scheduleToStartTimeout: string; summary: string; details: string; heartbeatTimeout: string; initialInterval: string; backoffCoefficient: undefined; ... 11 more ...; scheduleToCloseTimeout: string; }>, Record<...>> | ValidatorsOption<...> | undefined'.
  • L142:58: Argument of type '{ searchAttributes: SearchAttributeInput[]; input: string; messageType: string; scheduleToStartTimeout: string; summary: string; details: string; heartbeatTimeout: string; ... 13 more ...; scheduleToCloseTimeout: string; }' is not assignable to parameter of type 'StandaloneActivityFormData'.
  • L325:13: Type 'SearchAttributeInput[]' is not assignable to type '{ type: "Unspecified" | "Keyword" | "Text" | "Int" | "Double" | "Bool" | "KeywordList" | "Datetime"; label: string; value?: any; }[]'.
  • L353:13: Type 'undefined' is not assignable to type 'string'.
  • L355:13: Type 'undefined' is not assignable to type 'string'.
src/routes/(app)/+layout.svelte (1)
  • L61:23: Argument of type '(namespace: string) => { namespace: string; onClick: (namespace: string) => void; }' is not assignable to parameter of type '(value: string | null | undefined, index: number, array: (string | null | undefined)[]) => { namespace: string; onClick: (namespace: string) => void; }'.
src/routes/(app)/namespaces/[namespace]/activities/[activityId]/[runId]/+layout.svelte (1)
  • L50:4: Type 'ActivityExecution | undefined' is not assignable to type 'ActivityExecution'.

Generated by 🚫 dangerJS against 44dd56f

@rossedfort rossedfort merged commit 1ee50fc into main Feb 19, 2026
17 checks passed
@rossedfort rossedfort deleted the standalone-activities-route-fix branch February 19, 2026 19:34
temporal-cicd bot pushed a commit that referenced this pull request Feb 23, 2026
Auto-generated version bump from 2.45.3 to 2.45.4

Bump type: patch

Changes included:
- [`02b30a6e`](02b30a6) Use CountSchedules for counting schedules (#3100)
- [`90dfec88`](90dfec8) Add fallbacks for activities routes (#3154)
- [`f160628c`](f160628) DT-3564 - migrate schedules form to superforms (#3159)
- [`50d7bdf3`](50d7bdf) small css changes to nav components for better responsiveness (#3162)
- [`e3b4028b`](e3b4028) UI Copy Updates (#3165)
- [`3638919c`](3638919) add snippet for pre-release badge on standalone activities page (#3166)
- [`1ee50fcb`](1ee50fc) fix standalone activity routes and prep for release (#3168)
- [`7553e5b4`](7553e5b) Event history legend (#3160)
- [`562067a8`](562067a) Environment variable audit (#3163)
- [`51bdfd75`](51bdfd7) Card typography fixes (#3169)
- [`dfc6b453`](dfc6b45) fix schedule edit form infinite effect loop (#3172)
- [`07995e61`](07995e6) fix infinite effect bug when editing schedule with large input payload (#3174)
rossedfort added a commit that referenced this pull request Feb 23, 2026
Auto-generated version bump from 2.45.3 to 2.45.4

Bump type: patch

Changes included:
- [`02b30a6e`](02b30a6) Use CountSchedules for counting schedules (#3100)
- [`90dfec88`](90dfec8) Add fallbacks for activities routes (#3154)
- [`f160628c`](f160628) DT-3564 - migrate schedules form to superforms (#3159)
- [`50d7bdf3`](50d7bdf) small css changes to nav components for better responsiveness (#3162)
- [`e3b4028b`](e3b4028) UI Copy Updates (#3165)
- [`3638919c`](3638919) add snippet for pre-release badge on standalone activities page (#3166)
- [`1ee50fcb`](1ee50fc) fix standalone activity routes and prep for release (#3168)
- [`7553e5b4`](7553e5b) Event history legend (#3160)
- [`562067a8`](562067a) Environment variable audit (#3163)
- [`51bdfd75`](51bdfd7) Card typography fixes (#3169)
- [`dfc6b453`](dfc6b45) fix schedule edit form infinite effect loop (#3172)
- [`07995e61`](07995e6) fix infinite effect bug when editing schedule with large input payload (#3174)

Co-authored-by: rossedfort <11775628+rossedfort@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants