Skip to content

Add fallbacks for activities routes#3154

Merged
laurakwhit merged 3 commits intomainfrom
add-fallback-activities-routes
Feb 12, 2026
Merged

Add fallbacks for activities routes#3154
laurakwhit merged 3 commits intomainfrom
add-fallback-activities-routes

Conversation

@laurakwhit
Copy link
Copy Markdown
Collaborator

@laurakwhit laurakwhit commented Feb 11, 2026

Description & motivation 💭

Falls back to /activities/... routes if /activities-deprecated/... routes are not found.

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Feb 12, 2026 5:54pm

Request Review

@temporal-cicd
Copy link
Copy Markdown
Contributor

temporal-cicd bot commented Feb 11, 2026

Warnings
⚠️

📊 Strict Mode: 4 errors in 1 file (0.4% of 1126 total)

src/lib/services/workflow-activities-service.ts (4)
  • L56:28: No overload matches this call.
  • L81:28: No overload matches this call.
  • L106:28: No overload matches this call.
  • L132:28: No overload matches this call.

Generated by 🚫 dangerJS against e3cb790

@rossedfort
Copy link
Copy Markdown
Contributor

Can we know which route to used ahead of time based on a version number or do we have to make a request? Otherwise LGTM.

);
const version = page.data?.settings?.version;

if (version && !minimumVersionRequired('2.45.3', version)) {
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we know which route to used ahead of time based on a version number or do we have to make a request?

@rossedfort good point! Added a minimumVersionRequiredCheck.

@laurakwhit laurakwhit merged commit 90dfec8 into main Feb 12, 2026
18 checks passed
@laurakwhit laurakwhit deleted the add-fallback-activities-routes branch February 12, 2026 18:00
temporal-cicd bot pushed a commit that referenced this pull request Feb 23, 2026
Auto-generated version bump from 2.45.3 to 2.45.4

Bump type: patch

Changes included:
- [`02b30a6e`](02b30a6) Use CountSchedules for counting schedules (#3100)
- [`90dfec88`](90dfec8) Add fallbacks for activities routes (#3154)
- [`f160628c`](f160628) DT-3564 - migrate schedules form to superforms (#3159)
- [`50d7bdf3`](50d7bdf) small css changes to nav components for better responsiveness (#3162)
- [`e3b4028b`](e3b4028) UI Copy Updates (#3165)
- [`3638919c`](3638919) add snippet for pre-release badge on standalone activities page (#3166)
- [`1ee50fcb`](1ee50fc) fix standalone activity routes and prep for release (#3168)
- [`7553e5b4`](7553e5b) Event history legend (#3160)
- [`562067a8`](562067a) Environment variable audit (#3163)
- [`51bdfd75`](51bdfd7) Card typography fixes (#3169)
- [`dfc6b453`](dfc6b45) fix schedule edit form infinite effect loop (#3172)
- [`07995e61`](07995e6) fix infinite effect bug when editing schedule with large input payload (#3174)
rossedfort added a commit that referenced this pull request Feb 23, 2026
Auto-generated version bump from 2.45.3 to 2.45.4

Bump type: patch

Changes included:
- [`02b30a6e`](02b30a6) Use CountSchedules for counting schedules (#3100)
- [`90dfec88`](90dfec8) Add fallbacks for activities routes (#3154)
- [`f160628c`](f160628) DT-3564 - migrate schedules form to superforms (#3159)
- [`50d7bdf3`](50d7bdf) small css changes to nav components for better responsiveness (#3162)
- [`e3b4028b`](e3b4028) UI Copy Updates (#3165)
- [`3638919c`](3638919) add snippet for pre-release badge on standalone activities page (#3166)
- [`1ee50fcb`](1ee50fc) fix standalone activity routes and prep for release (#3168)
- [`7553e5b4`](7553e5b) Event history legend (#3160)
- [`562067a8`](562067a) Environment variable audit (#3163)
- [`51bdfd75`](51bdfd7) Card typography fixes (#3169)
- [`dfc6b453`](dfc6b45) fix schedule edit form infinite effect loop (#3172)
- [`07995e61`](07995e6) fix infinite effect bug when editing schedule with large input payload (#3174)

Co-authored-by: rossedfort <11775628+rossedfort@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants