Add support for query parameters in path matching#13
Merged
stevekinney merged 3 commits intomainfrom Jul 20, 2021
Merged
Conversation
feedmeapples
approved these changes
Jul 20, 2021
| expect(pathMatches('/workflows?query=param', '/queries')).toBe(false); | ||
| }); | ||
|
|
||
| it('should query params ignore do not match and the paths match', () => { |
Contributor
There was a problem hiding this comment.
typo?
Suggested change
| it('should query params ignore do not match and the paths match', () => { | |
| it('should ignore query params present in both paths and the paths match', () => { |
| ); | ||
| }); | ||
|
|
||
| it('should query params ignore do not match and the paths do not match', () => { |
Alex-Tideman
added a commit
that referenced
this pull request
Apr 2, 2026
Implement Tier 1 detections from existing data (#9, #11, #13, #15, #19, #23, #35) and Tier 2 detections from event history scanning (#8, #12, #26, #27, #28, #29, #30). Adds detectEventHistoryErrors with single-pass scanning and updates getApplicableCommonErrors to accept optional event history. All 35 error definitions now have active detection logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Adds support for query parameters when determining if one path is a match or child of the other.
Why?
When we support query parameters for filtering, we're going to want to have our active links still work. This is probably an edge case, but an easy enough fix.