Add better path matching for active links#11
Merged
stevekinney merged 1 commit intomainfrom Jul 14, 2021
Merged
Conversation
feedmeapples
approved these changes
Jul 14, 2021
| @@ -0,0 +1,13 @@ | |||
| export const pathMatches = (first: string, second: string): boolean => { | |||
Contributor
There was a problem hiding this comment.
should we also clear out query strings?
hferentschik
pushed a commit
to hferentschik/temporal-ui
that referenced
this pull request
Aug 13, 2025
Revert "[WFENG-2551] go straight to vault for SSO (temporalio#5)"
hferentschik
pushed a commit
to hferentschik/temporal-ui
that referenced
this pull request
Aug 13, 2025
* Revert "Merge pull request temporalio#11 from DataDog/revert-5-bg/skip-click" This reverts commit ca8fda6, reversing changes made to 8fce4c8. * use local storage * use ttl for state * don't minify * use current location for state redirect * move redirect to layout root * don't minify anymore * feedback skip instead of comment tests and clarify comments
Alex-Tideman
added a commit
that referenced
this pull request
Apr 2, 2026
Implement Tier 1 detections from existing data (#9, #11, #13, #15, #19, #23, #35) and Tier 2 detections from event history scanning (#8, #12, #26, #27, #28, #29, #30). Adds detectEventHistoryErrors with single-pass scanning and updates getApplicableCommonErrors to accept optional event history. All 35 error definitions now have active detection logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Adds a
pathMatchesutility function for theNavigationLinkcomponent that works when the current path is a subdirectory—for lack of a better word—of theNavigationLink.Why?
Previous to this change, the Workflows icon would no longer be highlighted if you navigated from
/workflowsto/workflows/:workflow_id/:run_idor some variation on that that. This addresses that.