Conversation
mtodor
force-pushed
the
mtodor/add-flakechecker-prefactor
branch
from
70d36e1 to
35ee249
Compare
porridge
approved these changes
Nov 14, 2024
porridge
left a comment
porridge
left a comment
There was a problem hiding this comment.
LGTM, with one nitpick and one potential error found.
janisz
approved these changes
Nov 14, 2024
mtodor
force-pushed
the
mtodor/add-flakechecker-prefactor
branch
from
35ee249 to
541e548
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is prefactoring for PR - #30.
Changes
1.21cmdfor commands,pkgfor shared packages) - with that change almost everything from root directory has been moved tocmd/junit2jiraj2jTestCasestruct instead of extendingTestCasefrom the package in order to keep changes in junit2jira easier to review.github.com/stackrox/junit2jira