Merged
Conversation
a2e05cf to
2e9d594
Compare
janisz
reviewed
Nov 11, 2024
Collaborator
janisz
left a comment
There was a problem hiding this comment.
I think it will be good to split repackaging from the flakechecker into 2 PRs.
Merged
2e9d594 to
6619bc3
Compare
porridge
reviewed
Nov 14, 2024
porridge
left a comment
There was a problem hiding this comment.
I started reviewing but I'm still struggling to understand the overall intent. Can you please point me at the periodic job, and maybe schedule half an hour to talk about the overall design / idea?
35ee249 to
541e548
Compare
ace9269 to
ba4fd4c
Compare
ba4fd4c to
f6c595b
Compare
3a7905e to
8eac3d1
Compare
porridge
requested changes
Dec 5, 2024
porridge
left a comment
There was a problem hiding this comment.
Looks good overall, but I have a whole bunch of nitpicks.
|
Also, it would be good to have documentation for this somewhere. Nothing fancy, basically what is in the PR description (after bringing it up to date) plus maybe a couple of sentences on the rationale. |
8eac3d1 to
705a2c1
Compare
705a2c1 to
0dfefc4
Compare
porridge
approved these changes
Jan 2, 2025
0dfefc4 to
eca6c51
Compare
06861af to
1ab7ff8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is introducing a new cli tool for evaluating if tests are known as flaky tests or not.
How it works
Flakechecker will handle information in the following way:
it checks all found failed jobs (logic taken from junit2jira)
for every failed test, it will check if it is defined as a flaky test in provided config
if a test is not found in known flaky tests configuration -> it will fail
if a test is found, but it didn't have 30 executions -> it will fail
if a test is found, but the defined threshold found in DB is above the definition in configuration -> it will fail
only if a test is found and the failure ratio in DB is below the defined threshold in config -> it will be reported as success to the CI pipeline - for that, we also need: chore(CI): Add config and call for flakechecker stackrox#13081