refactor: all unit/e2e tests to Golang#1524
Conversation
|
A single node development cluster (infra-pr-1524) was allocated in production infra for this PR. CI will attempt to deploy 🔌 You can connect to this cluster with: 🛠️ And pull infractl from the deployed dev infra-server with: 🚲 You can then use the dev infra instance e.g.: Further Development☕ If you make changes, you can commit and push and CI will take care of updating the development cluster. 🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with: LogsLogs for the development infra depending on your @redhat.com authuser: Or: |
… to test Argo Workflows, which is unnecessary
Required changes:
infractl create --rhacsflag is now always exposed, this is required becauseos.Argscan't be modified to include the flag if we rungo test.infractl create. We need to be able to mock the working environment in e2e tests and it was all a bit hard to readinfractl flavor list --jsonnow returns the flavor availability as a string, not enum int (iealphainstead of0). This improves usability.WorkflowTemplates are now removed, because they are unused (except tests - also refactored to just Workflows)WorkflowTemplate2Flavornow returns a flavor and a list of validation errors. The behaviour of logging and ignoring validation errors during service startup remains the same, but I implemented unit tests that check the errors.Also:
t.Parallel()- that was too unstable for my liking. Can be revisited later.