Skip to content

cleanup: remove unused WorkflowTemplate handling#1526

Merged
tommartensen merged 5 commits intotm/improve-test-performancefrom
tm/destroy-flavors
Mar 21, 2025
Merged

cleanup: remove unused WorkflowTemplate handling#1526
tommartensen merged 5 commits intotm/improve-test-performancefrom
tm/destroy-flavors

Conversation

@tommartensen
Copy link
Copy Markdown
Contributor

@tommartensen tommartensen commented Mar 18, 2025

This part of infra is unused and should be deleted.
Migrated the test WorkflowTemplates to Workflows, because there is still some value to check that the flavors have names, ... and simulate etc are required for E2E tests.

@tommartensen tommartensen self-assigned this Mar 18, 2025
@tommartensen tommartensen changed the base branch from master to tm/improve-test-performance March 18, 2025 10:44
@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Mar 18, 2025

A single node development cluster (infra-pr-1526) was allocated in production infra for this PR.

CI will attempt to deploy quay.io/rhacs-eng/infra-server:0.11.0-42-ga269b23c1c to it.

🔌 You can connect to this cluster with:

gcloud container clusters get-credentials infra-pr-1526 --zone us-central1-a --project acs-team-temp-dev

🛠️ And pull infractl from the deployed dev infra-server with:

nohup kubectl -n infra port-forward svc/infra-server-service 8443:8443 &
make pull-infractl-from-dev-server

🚲 You can then use the dev infra instance e.g.:

bin/infractl -k -e localhost:8443 whoami

⚠️ Any clusters that you start using your dev infra instance should have a lifespan shorter then the development cluster instance. Otherwise they will not be destroyed when the dev infra instance ceases to exist when the development cluster is deleted. ⚠️

Further Development

☕ If you make changes, you can commit and push and CI will take care of updating the development cluster.

🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:

make helm-deploy

Logs

Logs for the development infra depending on your @redhat.com authuser:

Or:

kubectl -n infra logs -l app=infra-server --tail=1 -f

@tommartensen tommartensen changed the title Tm/destroy flavors cleanup: remove unused WorkflowTemplate handling Mar 18, 2025
@tommartensen tommartensen marked this pull request as ready for review March 18, 2025 15:07
@tommartensen tommartensen requested a review from a team as a code owner March 18, 2025 15:07
Copy link
Copy Markdown
Contributor

@davdhacs davdhacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tommartensen tommartensen merged commit c6159cf into tm/improve-test-performance Mar 21, 2025
10 checks passed
@tommartensen tommartensen deleted the tm/destroy-flavors branch March 21, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants