Skip to content

Slim down Trino build#724

Merged
nightkr merged 4 commits intomainfrom
bugfix/trino-build-slim
Jun 19, 2024
Merged

Slim down Trino build#724
nightkr merged 4 commits intomainfrom
bugfix/trino-build-slim

Conversation

@nightkr
Copy link
Copy Markdown
Contributor

@nightkr nightkr commented Jun 19, 2024

Description

Drop RPM, clean up intermediate files, avoid some copying

Fixes #722

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [x] Add an entry to the CHANGELOG.md file
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

Drop RPM, clean up intermediate files, avoid some copying

Fixes #722
@nightkr nightkr marked this pull request as draft June 19, 2024 09:34
@nightkr
Copy link
Copy Markdown
Contributor Author

nightkr commented Jun 19, 2024

@nightkr nightkr marked this pull request as ready for review June 19, 2024 13:11
@nightkr nightkr requested a review from a team June 19, 2024 13:11
Copy link
Copy Markdown
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@nightkr nightkr added this pull request to the merge queue Jun 19, 2024
Merged via the queue into main with commit c608e9b Jun 19, 2024
@nightkr nightkr deleted the bugfix/trino-build-slim branch June 19, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trino rebuild broke the Docker build

2 participants