Merged
Conversation
Contributor
Author
|
@vmarkovtsev Travis is not triggered for some reason even for new PR. |
Collaborator
|
I think it works: https://travis-ci.com/src-d/ml-core/pull_requests Push |
Signed-off-by: Konstantin Slavnov <konstantin@sourced.tech>
Contributor
Author
|
ok, but at least I should remove Python 3.5 because it is unsupported by new bblfsh. UPD: in case you wonder why: bblfsh/python-client#154 |
vmarkovtsev
approved these changes
Jul 31, 2019
Collaborator
vmarkovtsev
left a comment
vmarkovtsev
left a comment
There was a problem hiding this comment.
Really, did it work?! Too smooth to be true.
Collaborator
|
cc @Guillemdb This is how the port should look like: only changing the imports and the tests stayed the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
duplicate of #31