This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Require Python ≥ 3.6.#154
Merged
creachadair merged 1 commit intobblfsh:masterfrom Apr 24, 2019
creachadair:py36iss153
Merged
Conversation
Signed-off-by: M. J. Fromberger <michael.j.fromberger@gmail.com>
dennwc
approved these changes
Apr 24, 2019
Contributor
Author
|
I guess in principle this may count as a breaking change. Should we also bump the version number? |
Member
|
A quick search only shows this file, but it doesn't mention the version. Regarding the breaking change, I think we already bumped the major version when switching to SDKv3, so it should be fine. |
Contributor
Author
Ok, thanks. In that case I will merge this once I have updated the description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of our code uses type annotations on variable declarations, which were introduced by PEP 526 with Python 3.6. There does not seem to be any good reason not to prefer newer versions of Python 3, since we are already incompatible with Python 2, so this change drops the 3.4 and 3.5 tags from the PyPI configuration.
Fixes #153.