Skip to content

Rearrange architecture according to RFC#1977

Merged
atilafassina merged 9 commits intomainfrom
repo-architecture
Oct 2, 2025
Merged

Rearrange architecture according to RFC#1977
atilafassina merged 9 commits intomainfrom
repo-architecture

Conversation

@atilafassina
Copy link
Member

@atilafassina atilafassina commented Sep 20, 2025

Part of the work towards the Fullstack Primitives initiative.

Caution

landing page is failing because I need to fix the routing in Netlify before merging.

@atilafassina atilafassina added the hold waiting for something to be addressed label Sep 20, 2025
@atilafassina atilafassina self-assigned this Sep 20, 2025
@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2025

⚠️ No Changeset found

Latest commit: b234c04

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Sep 20, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit b234c04
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/68ded321d414ba00087376fb
😎 Deploy Preview https://deploy-preview-1977--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 20, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@solidjs/start@1977

commit: b234c04

@atilafassina atilafassina marked this pull request as ready for review September 23, 2025 09:36
@birkskyum
Copy link
Member

birkskyum commented Sep 29, 2025

it looks like /tests is here nested inside of /apps/tests. In the design suggested it looks like it should be at /tests at root level

@katywings
Copy link
Contributor

One of the past inconsistencies was with code formatting. We do have a prettier config, but I think it isn't very enforced, neither README.md, nor CONTRIBUTING.md talks about it, and there is no formatting/linting script.

Normally I would have recommended to add it here, but since there are lots of files with "wrong" formatting, I suggest to start enforcing this in either devinxi or post-devinxi. If we do it here, I fear that the merge conflicts would be a huge waste of time 😅.

@atilafassina
Copy link
Member Author

it looks like /tests is here nested inside of /apps/tests. In the design suggested it looks like it should be at /tests at root level

that was a typo in the docs. Intention was to have them in /apps because those are indeed SolidStart apps

@atilafassina atilafassina enabled auto-merge (squash) October 2, 2025 19:33
@atilafassina atilafassina merged commit 710350c into main Oct 2, 2025
9 checks passed
@atilafassina atilafassina deleted the repo-architecture branch October 2, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold waiting for something to be addressed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants