Conversation
|
5e152f2 to
f3f1b16
Compare
More templates
commit: |
|
I can see the significant convenience of this for local development, but this change won't work on the main branch for a number of reasons, so it has to be reverted before merging into that. Alternatively, I've previously use a small script that converted the import paths to be relative like here in few ms, and that was an okay development experience as well. The main issues that makes this incompat with main are:
A middleground that resolves the latter could be using overrides like tanstack/router, where in local development, the examples will resolve ot local packages, but if cloned, they'll resolve to the npm packages. The package overrides doesn't resolve the version conflict of i.e. mediakit/auth though: |
|
solid-cli has been updated to use solid-start examples from the solidjs/templates repo, so this repo can move forward with just having some fixtures that are imported from TS |
|
let's try this one once we merge #1977 |
|
Probably easier to remake than rebase at this point. |
|
Agreed, will close and recreate |
This allows us to not have to build the Start package before testing it in examples.
It requires us to import
src/configdirectly inside examples, as Vite doesn't transpile files from packages when importing them into the config, but I'd say this is worth it for the workflow improvement - Vite will even reload automatically when modifying the Start config implementation now.It also requires making some modifications to our publishing process, since the default
exportsfield now points to.tsfiles.pnpm publishwill automatically use the.jsexports defined inpublishConfig, but changesets and pkg.pr.new require a smalljqcommand to swap out theexportsfield before publishing.