Conversation
Add internal settings generation for passive node
fix internal settings update
badrogger
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a consistent step to save internal node settings during initialization, restoration, migration, and update operations across various node types (
FAIRandSKALE). The main change is the addition of thesave_internal_settingsfunction call before validating and saving node settings, ensuring that internal state is properly recorded for each operation.Enhancements to node lifecycle operations:
save_internal_settingscall beforevalidate_and_save_node_settingsin all relevant functions forFAIRnodes, including boot, active, and common modules, covering initialization, update, migration, and restoration operations. [1] [2] [3] [4] [5] [6]save_internal_settingsstep forSKALEnodes in initialization, restoration, and passive update functions. [1] [2] [3]Imports and code organization:
FAIRandSKALEnode modules to includesave_internal_settingsalongsidevalidate_and_save_node_settingsfor clarity and consistency. [1] [2] [3]These changes help ensure that internal node settings are always saved as part of the node lifecycle, reducing the risk of inconsistent state and making future debugging and maintenance easier.