Skip to content

Develop to beta - passive node fix#970

Merged
dmytrotkk merged 4 commits intobetafrom
develop
Mar 6, 2026
Merged

Develop to beta - passive node fix#970
dmytrotkk merged 4 commits intobetafrom
develop

Conversation

@dmytrotkk
Copy link
Collaborator

This pull request introduces a consistent step to save internal node settings during initialization, restoration, migration, and update operations across various node types (FAIR and SKALE). The main change is the addition of the save_internal_settings function call before validating and saving node settings, ensuring that internal state is properly recorded for each operation.

Enhancements to node lifecycle operations:

  • Added save_internal_settings call before validate_and_save_node_settings in all relevant functions for FAIR nodes, including boot, active, and common modules, covering initialization, update, migration, and restoration operations. [1] [2] [3] [4] [5] [6]
  • Applied the same save_internal_settings step for SKALE nodes in initialization, restoration, and passive update functions. [1] [2] [3]

Imports and code organization:

  • Updated imports in FAIR and SKALE node modules to include save_internal_settings alongside validate_and_save_node_settings for clarity and consistency. [1] [2] [3]

These changes help ensure that internal node settings are always saved as part of the node lifecycle, reducing the risk of inconsistent state and making future debugging and maintenance easier.

@dmytrotkk dmytrotkk merged commit 6f1b886 into beta Mar 6, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants