Skip to content

fix internal settings update#969

Merged
dmytrotkk merged 1 commit intodevelopfrom
fix-passive-node-settings
Mar 6, 2026
Merged

fix internal settings update#969
dmytrotkk merged 1 commit intodevelopfrom
fix-passive-node-settings

Conversation

@dmytrotkk
Copy link
Collaborator

This pull request introduces a consistent step to save internal node settings before validating and saving node settings across various node lifecycle operations. The main change is the addition of calls to save_internal_settings in several functions related to node initialization, restoration, migration, and updates, ensuring that internal settings are properly recorded whenever node mode or type changes.

Enhancements to node lifecycle operations:

  • Added save_internal_settings calls to the init, restore, update, and migrate_from_boot functions in node_cli/fair/active.py, node_cli/fair/boot.py, and node_cli/fair/common.py to ensure internal settings are saved before proceeding with node configuration. [1] [2] [3] [4] [5] [6] [7]

Imports and code consistency:

  • Updated imports in relevant files to include save_internal_settings from node_cli.utils.settings, maintaining consistency and enabling the new functionality. [1] [2] [3]

@dmytrotkk dmytrotkk self-assigned this Mar 6, 2026
@dmytrotkk dmytrotkk linked an issue Mar 6, 2026 that may be closed by this pull request
@dmytrotkk dmytrotkk merged commit f318a95 into develop Mar 6, 2026
2 of 3 checks passed
@dmytrotkk dmytrotkk deleted the fix-passive-node-settings branch March 6, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ValidationError during passive node setup

2 participants