Conversation
badrogger
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a consistent step to save internal node settings before validating and saving node settings across various node lifecycle operations. The main change is the addition of calls to
save_internal_settingsin several functions related to node initialization, restoration, migration, and updates, ensuring that internal settings are properly recorded whenever node mode or type changes.Enhancements to node lifecycle operations:
save_internal_settingscalls to theinit,restore,update, andmigrate_from_bootfunctions innode_cli/fair/active.py,node_cli/fair/boot.py, andnode_cli/fair/common.pyto ensure internal settings are saved before proceeding with node configuration. [1] [2] [3] [4] [5] [6] [7]Imports and code consistency:
save_internal_settingsfromnode_cli.utils.settings, maintaining consistency and enabling the new functionality. [1] [2] [3]