Skip to content

Also support build sanity check on <3.11 #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jarrodmillman merged 2 commits into from
Sep 28, 2023
Merged

Also support build sanity check on <3.11 #124

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13ff29c
Also support build sanity check on <3.11
stefanv Sep 28, 2023
22d53f8
Add comment on why sanity check is necessary
stefanv Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions spin/cmds/meson.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,12 +275,20 @@ def test(ctx, pytest_args, n_jobs, tests, verbose, coverage=False):
site_path = _set_pythonpath()

# Sanity check that library built properly
#
# We do this because `pytest` swallows exception messages originating from `conftest.py`.
# This can sometimes suppress useful information raised by the package on init.
if sys.version_info[:2] >= (3, 11):
p = _run([sys.executable, "-P", "-c", f"import {package}"], sys_exit=False)
if p.returncode != 0:
print(f"As a sanity check, we tried to import {package}.")
print("Stopping. Please investigate the build error.")
sys.exit(1)
else:
p = _run(
[sys.executable, "-c", f"import sys; del sys.path[0]; import {package}"],
sys_exit=False,
)
if p.returncode != 0:
print(f"As a sanity check, we tried to import {package}.")
print("Stopping. Please investigate the build error.")
sys.exit(1)

if (n_jobs != "1") and ("-n" not in pytest_args):
pytest_args = ("-n", str(n_jobs)) + pytest_args
Expand Down