Skip to content

Also support build sanity check on <3.11 #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jarrodmillman merged 2 commits into from
Sep 28, 2023
Merged

Also support build sanity check on <3.11 #124

jarrodmillman merged 2 commits into from
Sep 28, 2023

Conversation

@stefanv
Copy link
Member

@stefanv stefanv commented Sep 28, 2023

/cc @mattip

@stefanv stefanv added the type: Enhancement New feature or request label Sep 28, 2023
@mattip
Copy link
Contributor

mattip commented Sep 28, 2023

Thanks, LGTM. Maybe add a comment that pytest swallows the chained error, apparently since it occurs when importing conftest.py very early in pytest startup

@jarrodmillman jarrodmillman merged commit 6214806 into scientific-python:main Sep 28, 2023
@jarrodmillman jarrodmillman added this to the 0.8 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jarrodmillman jarrodmillman jarrodmillman approved these changes

Assignees

No one assigned

Labels

type: Enhancement New feature or request

Projects

None yet

Milestone

0.8

Development

Successfully merging this pull request may close these issues.

3 participants

@stefanv @mattip @jarrodmillman