SoundSource.cpp: return AVERROR_EOF when buffer is empty#747
Closed
Lihis wants to merge 1 commit intorwengine:mainfrom
Closed
SoundSource.cpp: return AVERROR_EOF when buffer is empty#747Lihis wants to merge 1 commit intorwengine:mainfrom
Lihis wants to merge 1 commit intorwengine:mainfrom
Conversation
Contributor
|
Member
|
Thanks for the fix, Start new game is now working again! |
Member
|
(github is broken and doesn't detect the merge, so closing manually) |
Collaborator
Author
|
Merge commit e20356b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On latest master (0f83c16) when I click "start new game", nothing happens.
Debugged this a bit it seems the
avformat_find_stream_infohangs in SoundSource.cpp. Looks like the read_packet function is called over and over again even the functions returns0.But if
AVERROR_EOFis returned when the buffer is empty, it fixes the hanging for me. Is this related some API change or something else? Would need to figure it out..