Fixes compatibility with newer ffmpeg versions.#746
Merged
tsjost merged 3 commits intorwengine:mainfrom Apr 20, 2024
Dygear:ffmpeg5-fixes
Merged
Fixes compatibility with newer ffmpeg versions.#746tsjost merged 3 commits intorwengine:mainfrom Dygear:ffmpeg5-fixes
tsjost merged 3 commits intorwengine:mainfrom
Dygear:ffmpeg5-fixes
Conversation
Fixes `Error: assigning to 'AVCodec *' from 'const AVCodec *' discards qualifiers`.
|
+1 |
Lihis
reviewed
Nov 30, 2023
Lihis
requested changes
Dec 1, 2023
Contributor
Author
|
Ok took your suggestion @Lihis, hopefully this can be closed now once merged. |
Co-authored-by: Tomi Lähteenmäki <lihis@lihis.net>
Contributor
Author
|
@Lihis Done |
Lihis
approved these changes
Jan 19, 2024
Member
|
Thanks for the fix and review! This fixes the build error, but Start new game soft-hangs with audio still playing; not yet sure if this also has something to do with newer ffmpeg, or just something weird with my machine. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Error: assigning to 'AVCodec *' from 'const AVCodec *' discards qualifiers.Building on macOS Sonoma 14.1 (23B74), using a M2 Max in an
arch -x86_64 zshenvironment.Fixes the error by using the auto keyword to infer the correct type.
It should be noted that this might not be the best way to handle this. Indeed right after this, the compiler notes that the
codecvariable is never actually used in either location. Perhaps the author of the original commit for this line, Filip Gawin, could explain what the intention was with this line. Removing this line completely also fixes the error, but I'm unable to tell if it has side effects.