Skip to content

JSON.load invoke the proc callback directly from the parser. #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
byroot merged 2 commits into from
Mar 27, 2025
Merged

JSON.load invoke the proc callback directly from the parser. #774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73d2137
JSON.load invoke the proc callback directly from the parser.
byroot Mar 26, 2025
f411ddf
Move `create_addtions` logic in Ruby.
byroot Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Changes

* Fix `JSON.load` proc argument to substitute the parsed object with the return value.
This better match `Marshal.load` behavior.
* Deprecate `JSON.fast_generate` (it's not any faster, so pointless).
* Deprecate `JSON.load_default_options`.
* Deprecate `JSON.unsafe_load_default_options`.
Expand Down
1 change: 0 additions & 1 deletion ext/json/ext/parser/extconf.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
have_func("rb_enc_interned_str", "ruby.h") # RUBY_VERSION >= 3.0
have_func("rb_hash_new_capa", "ruby.h") # RUBY_VERSION >= 3.2
have_func("rb_hash_bulk_insert", "ruby.h") # Missing on TruffleRuby
have_func("rb_category_warn", "ruby.h") # Missing on TruffleRuby
have_func("strnlen", "string.h") # Missing on Solaris 10

append_cflags("-std=c99")
Expand Down
190 changes: 30 additions & 160 deletions ext/json/ext/parser/parser.c
View file
Open in desktop

Large diffs are not rendered by default.

Loading