JSON.load invoke the proc callback directly from the parser.#774
Merged
byroot merged 2 commits intoruby:masterfrom Mar 27, 2025
Merged
JSON.load invoke the proc callback directly from the parser.#774byroot merged 2 commits intoruby:masterfrom
byroot merged 2 commits intoruby:masterfrom
Conversation
casperisfine
force-pushed
the
on-parse-callback
branch
2 times, most recently
from
a488bed to
5b715b6
Compare
And substitute the return value like `Marshal.load` doesm which I can only assume was the intent. This also open the door to re-implement all the `create_addition` logic in `json/common.rb`.
casperisfine
force-pushed
the
on-parse-callback
branch
from
5b715b6 to
0d14f67
Compare
casperisfine
force-pushed
the
on-parse-callback
branch
2 times, most recently
from
68c25e9 to
b37e6cf
Compare
By leveraging the `on_load` callback we can move all this logic out of the parser. Which mean we no longer have to duplicate that logic in both parser and that we'll later be able to extract it entirely from the gem.
casperisfine
force-pushed
the
on-parse-callback
branch
from
b37e6cf to
f411ddf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And substitute the return value like
Marshal.loaddoesm which I can only assume was the intent.This also allows re-implement all the
create_additionlogic injson/common.rb, and open the door to extract it to another gem in the future.