Skip to content

Workaround for test-bundled-gems at ruby/ruby repo #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsbt merged 7 commits into from
Jan 18, 2024
Merged

Workaround for test-bundled-gems at ruby/ruby repo #283

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
55a9f83
Added current directory to LOAD_PATH of assert_in_out_err for test-bu…
hsbt Jan 17, 2024
1bbca81
Support ruby/bigdecimal repository cases
hsbt Jan 17, 2024
bf5ebd0
Simplified LOAD_PATH delegation for assert_in_out_err
hsbt Jan 17, 2024
758fc62
We need to care assert_no_memory_leak too
hsbt Jan 17, 2024
2aab78b
BigDecimal() is obsoleted today. We shouldn't test it
hsbt Jan 17, 2024
c25d93e
BigDecimal.allocate is obsoleted too
hsbt Jan 17, 2024
a77d775
Don't use : for Windows platforms
hsbt Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions test/bigdecimal/test_bigdecimal.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1768,7 +1768,8 @@ def test_ctov
def test_split_under_gc_stress
bug3258 = '[ruby-dev:41213]'
expect = 10.upto(20).map{|i|[1, "1", 10, i+1].inspect}
assert_in_out_err(%w[-rbigdecimal --disable-gems], <<-EOS, expect, [], bug3258)
paths = $LOAD_PATH.map{|path| "-I#{path}" }
assert_in_out_err([*paths, "-rbigdecimal", "--disable-gems"], <<-EOS, expect, [], bug3258)
GC.stress = true
10.upto(20) do |i|
p BigDecimal("1"+"0"*i).split
Expand All @@ -1777,7 +1778,8 @@ def test_split_under_gc_stress
end

def test_coerce_under_gc_stress
assert_in_out_err(%w[-rbigdecimal --disable-gems], <<-EOS, [], [])
paths = $LOAD_PATH.map{|path| "-I#{path}" }
assert_in_out_err([*paths, "-rbigdecimal", "--disable-gems"], <<-EOS, [], [])
expect = ":too_long_to_embed_as_string can't be coerced into BigDecimal"
b = BigDecimal("1")
GC.stress = true
Expand Down Expand Up @@ -1884,7 +1886,8 @@ def test_BigMath_exp_with_rational
end

def test_BigMath_exp_under_gc_stress
assert_in_out_err(%w[-rbigdecimal --disable-gems], <<-EOS, [], [])
paths = $LOAD_PATH.map{|path| "-I#{path}" }
assert_in_out_err([*paths, "-rbigdecimal", "--disable-gems"], <<-EOS, [], [])
expect = ":too_long_to_embed_as_string can't be coerced into BigDecimal"
10.times do
begin
Expand Down Expand Up @@ -2026,7 +2029,8 @@ def test_BigMath_log_with_reciprocal_of_42
end

def test_BigMath_log_under_gc_stress
assert_in_out_err(%w[-rbigdecimal --disable-gems], <<-EOS, [], [])
paths = $LOAD_PATH.map{|path| "-I#{path}" }
assert_in_out_err([*paths, "-rbigdecimal", "--disable-gems"], <<-EOS, [], [])
expect = ":too_long_to_embed_as_string can't be coerced into BigDecimal"
10.times do
begin
Expand Down Expand Up @@ -2073,7 +2077,8 @@ def test_to_d
end if RUBY_VERSION < '2.5' # mathn was removed from Ruby 2.5

def test_bug6406
assert_in_out_err(%w[-rbigdecimal --disable-gems], <<-EOS, [], [])
paths = $LOAD_PATH.map{|path| "-I#{path}" }
assert_in_out_err([*paths, "-rbigdecimal", "--disable-gems"], <<-EOS, [], [])
Thread.current.keys.to_s
EOS
end
Expand Down Expand Up @@ -2283,21 +2288,14 @@ def test_bsearch_for_bigdecimal

def assert_no_memory_leak(code, *rest, **opt)
code = "8.times {20_000.times {begin #{code}; rescue NoMemoryError; end}; GC.start}"
super(["-rbigdecimal"],
paths = $LOAD_PATH.map{|path| "-I#{path}" }
super([*paths, "-rbigdecimal"],
"b = BigDecimal('10'); b.nil?; " \
"GC.add_stress_to_class(BigDecimal); "\
"#{code}", code, *rest, rss: true, limit: 1.1, **opt)
end

if EnvUtil.gc_stress_to_class?
def test_no_memory_leak_allocate
assert_no_memory_leak("BigDecimal.allocate")
end

def test_no_memory_leak_initialize
assert_no_memory_leak("BigDecimal()")
end

def test_no_memory_leak_BigDecimal
assert_no_memory_leak("BigDecimal('10')")
assert_no_memory_leak("BigDecimal(b)")
Expand Down