Skip to content

Conversation

@hsbt
Copy link
Member

@hsbt hsbt commented Jan 17, 2024

There is no way to load bigdecimal extension in assert_in_out_err with make test-bundled-gems of ruby/ruby repository.

I added extension directory for that explicitly. I know this is ad-hoc solution. We should provide these paths to like assert_in_out_err assertions in ruby/ruby side.

@hsbt
Copy link
Member Author

hsbt commented Jan 17, 2024

https://github.com/ruby/bigdecimal/actions/runs/7552785831/job/20562319734?pr=283 is caused by io-console side at ruby/io-console#65.

I will release fixed version tomorrow.

@hsbt hsbt force-pushed the fix-test-bundled-gems-3-4 branch from 28023cd to 3d185d2 Compare January 17, 2024 12:13
@hsbt hsbt force-pushed the fix-test-bundled-gems-3-4 branch from 3d185d2 to c25d93e Compare January 18, 2024 02:33
@hsbt hsbt merged commit 3816e76 into master Jan 18, 2024
@hsbt hsbt deleted the fix-test-bundled-gems-3-4 branch January 18, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants