Skip to content

Update title to be Dash instead of dash #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rpkyle merged 2 commits into from
May 15, 2020
Merged

Update title to be Dash instead of dash #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3aca18a
Update title to be Dash instead of dash
chriddyp May 15, 2020
47db182
:hammer: fix unit test
May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions R/dash.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,11 @@
#' from the Dash backend. The latter may offer improved performance relative
#' to callbacks written purely in R.
#' }
#' \item{`title("dash")`}{
#' The title of the app. If no title is supplied, Dash for R will use 'dash'.
#' \item{`title("Dash")`}{
#' The title of the app. If no title is supplied, Dash for R will use 'Dash'.
#' }
#' \item{`title("dash")`}{
#' The title of the app. If no title is supplied, Dash for R will use 'dash'.
#' \item{`title("Dash")`}{
#' The title of the app. If no title is supplied, Dash for R will use 'Dash'.
#' }
#' \item{`callback_context()`}{
#' The `callback_context` method permits retrieving the inputs which triggered
Expand Down Expand Up @@ -293,7 +293,7 @@ Dash <- R6::R6Class(
# save relevant args as private fields
if (!is.null(name)) {
warning(sprintf(
"The supplied application title, '%s', should be set using the title() method, or passed via index_string() or interpolate_index(); it has been ignored, and 'dash' will be used instead.",
"The supplied application title, '%s', should be set using the title() method, or passed via index_string() or interpolate_index(); it has been ignored, and 'Dash' will be used instead.",
name),
call. = FALSE
)
Expand Down Expand Up @@ -935,7 +935,7 @@ Dash <- R6::R6Class(
# ------------------------------------------------------------------------
# specify a custom title
# ------------------------------------------------------------------------
title = function(string = "dash") {
title = function(string = "Dash") {
assertthat::assert_that(is.character(string))
private$name <- string
},
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-index.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ test_that("Customizing title using `name` produces a warning", {

expect_warning(
Dash$new(name="Testing"),
"The supplied application title, 'Testing', should be set using the title() method, or passed via index_string() or interpolate_index(); it has been ignored, and 'dash' will be used instead.",
"The supplied application title, 'Testing', should be set using the title() method, or passed via index_string() or interpolate_index(); it has been ignored, and 'Dash' will be used instead.",
fixed=TRUE
)
})