Skip to content

Conversation

@chriddyp
Copy link
Member

Convention in browser tabs is for the title to be upper case, dash is the odd one out right now

image

@chriddyp chriddyp requested a review from rpkyle May 15, 2020 18:50
@chriddyp chriddyp changed the base branch from master to dev May 15, 2020 18:50
@chriddyp chriddyp changed the base branch from dev to master May 15, 2020 18:50
@rpkyle
Copy link
Contributor

rpkyle commented May 15, 2020

@chriddyp Looks good, I'll fix the broken test now so that we can merge this one.

Copy link
Contributor

@rpkyle rpkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 once the tests are passing again.

@rpkyle rpkyle merged commit 9c5a307 into master May 15, 2020
@rpkyle rpkyle deleted the chriddyp-patch-1 branch May 15, 2020 19:21
@rpkyle rpkyle mentioned this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants