Skip to content

Expand protobuf version constraint to include v6.x #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rohanshah18 wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −5
Open

Expand protobuf version constraint to include v6.x #565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb68023
expand protobuf version to include v6.x
rohanshah18 Dec 16, 2025
0f60567
fix regex and target-version
rohanshah18 Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/publish-to-pypi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ jobs:

- name: Bump pyproject.toml version
run: |
python -c "import re; content = open('pyproject.toml').read(); content = re.sub(r'version = \"[^\"]+\"', 'version = \"${{ steps.bump.outputs.version }}\"', content); open('pyproject.toml', 'w').write(content)"
python -c "import re; content = open('pyproject.toml').read(); content = re.sub(r'^version = \"[^\"]+\"', 'version = \"${{ steps.bump.outputs.version }}\"', content, flags=re.MULTILINE); open('pyproject.toml', 'w').write(content)"
Copy link
Contributor Author

@rohanshah18 rohanshah18 Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realized the target-version in pyproject.toml was incorrectly changed by the publish-to-pypi workflow. The regex re.sub(r'version = "[^\"]+"', ...) is too broad and matches both:
version = "7.3.0" (line# 3)
target-version = "py310" (line#125)
When v8.0.0 was released (the first release after the uv migration), both lines were changed to "8.0.0" (PR). This went unnoticed because the release commit used [skip ci].


- name: Build Python client
run: make package
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ grpc = [
"grpcio>=1.68.0; python_version>='3.13'",
"googleapis-common-protos>=1.66.0",
"lz4>=3.1.3",
"protobuf>=5.29.5,<6.0.0",
"protobuf>=5.29.5,<7.0.0",
"protoc-gen-openapiv2>=0.0.1,<0.1.0",
]
asyncio = [
Expand Down Expand Up @@ -122,7 +122,7 @@ exclude = [

line-length = 100
indent-width = 4
target-version = "8.0.0"
target-version = "py310"

[tool.ruff.lint]
# Enable Pyflakes (`F`) and a subset of the pycodestyle (`E`) codes by default.
Expand Down
4 changes: 2 additions & 2 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading