Expand protobuf version constraint to include v6.x #565
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanshah18
commented
Dec 16, 2025
| [[package]] | ||
| name = "pinecone" | ||
| version = "7.3.0" | ||
| version = "8.0.0" |
Contributor
Author
There was a problem hiding this comment.
Not sure why version was not updated to 8.0.0 but running uv sync will update this to current pinecone python sdk version.
rohanshah18
commented
Dec 16, 2025
| - name: Bump pyproject.toml version | ||
| run: | | ||
| python -c "import re; content = open('pyproject.toml').read(); content = re.sub(r'version = \"[^\"]+\"', 'version = \"${{ steps.bump.outputs.version }}\"', content); open('pyproject.toml', 'w').write(content)" | ||
| python -c "import re; content = open('pyproject.toml').read(); content = re.sub(r'^version = \"[^\"]+\"', 'version = \"${{ steps.bump.outputs.version }}\"', content, flags=re.MULTILINE); open('pyproject.toml', 'w').write(content)" |
Contributor
Author
There was a problem hiding this comment.
Realized the target-version in pyproject.toml was incorrectly changed by the publish-to-pypi workflow. The regex re.sub(r'version = "[^\"]+"', ...) is too broad and matches both:
version = "7.3.0" (line# 3)
target-version = "py310" (line#125)
When v8.0.0 was released (the first release after the uv migration), both lines were changed to "8.0.0" (PR). This went unnoticed because the release commit used [skip ci].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current protobuf dependency constraint (
>=5.29.5,<6.0.0) blocks users from using protobuf 6.x. Some users may want or need to use protobuf 6.x in their environments, and the current upper bound prevents this.Solution
Updated the protobuf version constraint from
<6.0.0to<7.0.0inpyproject.toml, allowing both protobuf 5.x and 6.x.According to the Protocol Buffers Cross-Version Runtime Guarantee, code generated for major version V is supported by runtimes of versions V and V+1. Our proto files were generated with protobuf 5.x, so they should be compatible with 6.x runtimes.
Verified locally: Successfully imported proto modules and ran all gRPC unit tests with protobuf 6.33.2 installed.
Security note: CVE-2025-4565 is fixed in protobuf 5.29.5 and 6.31.1. The existing
>=5.29.5lower bound ensures 5.x users get patched versions.Type of Change
Test Plan