[NEW] Allows dot-notation to match against a complex structure when using matchesKeyInQuery#4399
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4399 +/- ##
==========================================
- Coverage 92.7% 92.66% -0.04%
==========================================
Files 118 118
Lines 8346 8346
==========================================
- Hits 7737 7734 -3
- Misses 609 612 +3
Continue to review full report at Codecov.
|
flovilmart
left a comment
flovilmart
left a comment
There was a problem hiding this comment.
The solution has an inherent simple beauty in it, it’s wonderful.
spec/ParseQuery.spec.js
Outdated
| }) | ||
| }); | ||
|
|
||
| it('should match complex structure with dot notation when using matchesKeyInQuery', function(done) { |
There was a problem hiding this comment.
Should probably change the description to use doesNotMatchKeyInQuery
|
Just a note tests are good here 👍, failure is the unrelated moment.js regex vuln. |
montymxb
left a comment
montymxb
left a comment
There was a problem hiding this comment.
Excellent!
On another note since this is new functionality we should be documenting this as well. Docs PR and such.
|
Thanks @acinader and others! |
4 participants
Just finishes out #4308 which @bohemima did the heavy lifting on. Fixes #4346.
It's too useful to let fester ;)