Add dot notation key in query examples#488
Merged
Conversation
montymxb
previously requested changes
Dec 2, 2017
Contributor
montymxb
left a comment
montymxb
left a comment
There was a problem hiding this comment.
Additions look good. We probably want an example for the ios sdk while we're at it though.
acinader
force-pushed
the
add-dot-notation-key-in-query-examples
branch
from
00f8748 to
3caf6c4
Compare
acinader
force-pushed
the
add-dot-notation-key-in-query-examples
branch
from
3caf6c4 to
a8b46aa
Compare
Contributor
Author
|
@montymxb can you take another look at this |
Contributor
|
I've fixed a couple of formatting issues. It makes sense to get this merged in even without the iOS example and then we can open an issue. |
Contributor
|
@acinader are you happy for me to merge this in? |
Contributor
Author
|
yeah, getting my doc improvement from november of 17 merged in would make me happy. thanks for asking ;) |
Contributor
|
We're really prompt here ;) |
Contributor
|
Also I noticed that only the PHP docs have section headings for the different types of query constraints which is much easier to navigate than the other docs - I think I'll open an issue/pr for this too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see parse-community/parse-server#4399