Polaris support #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request adds support for the POLARIS (Planning and Operations Language for Agent-based Regional Integrated Simulation) transportation modeling system to SimWrapper. The integration enables visualization of POLARIS model outputs including spatial data from SQLite databases.
Key Changes:
- New plugin architecture for POLARIS with database caching and memory management
- Support for multiple database types (supply, demand, result) with cross-database querying
- Data-driven styling system with color encoding and filtering capabilities
- Vue component for rendering POLARIS visualizations with legend support
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/plugins/polaris/usePolaris.ts | Core utilities for data loading with memory optimization and loading queue management |
| src/plugins/polaris/types.ts | TypeScript type definitions for POLARIS configurations and data structures |
| src/plugins/polaris/styling.ts | Styling system for data-driven visualization with color/size mapping |
| src/plugins/polaris/db.ts | Database utility functions for SQLite operations and GeoJSON feature extraction |
| src/plugins/polaris/PolarisReader.vue | Main Vue component for POLARIS data visualization |
| src/plugins/polaris/PolarisFileSystem.ts | File system handler for POLARIS project detection and database loading |
| src/plugins/polaris/reader.scss | Styles for the POLARIS viewer component |
| src/plugins/polaris/i18n.ts | Internationalization configuration (English and German) |
| src/dash-panels/polaris.vue | Dashboard panel wrapper for POLARIS visualizations |
| src/plugins/pluginRegistry.ts | Plugin registration for polaris.yaml file pattern |
| src/dash-panels/_allPanels.ts | Panel registration for dashboard integration |
| package-lock.json | Added dependencies for cartocolor, spl.js, sql.js, sqlite3, and spatialite |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/plugins/polaris/styling.ts
Outdated
Comment on lines
2
to
8
| * Styling utilities for AequilibraE plugin | ||
| * | ||
| * This module provides functions for building visual styles from data. | ||
| * It handles color encoding, size mapping, filtering, and the creation | ||
| * of typed arrays optimized for WebGL rendering. | ||
| * | ||
| * @fileoverview Data-Driven Styling System for AequilibraE |
There was a problem hiding this comment.
The fileoverview comment incorrectly states "Data-Driven Styling System for AequilibraE" when this file is for the POLARIS plugin. This should be updated to reflect the correct plugin name.
Suggested change
| * Styling utilities for AequilibraE plugin | |
| * | |
| * This module provides functions for building visual styles from data. | |
| * It handles color encoding, size mapping, filtering, and the creation | |
| * of typed arrays optimized for WebGL rendering. | |
| * | |
| * @fileoverview Data-Driven Styling System for AequilibraE | |
| * Styling utilities for POLARIS plugin | |
| * | |
| * This module provides functions for building visual styles from data. | |
| * It handles color encoding, size mapping, filtering, and the creation | |
| * of typed arrays optimized for WebGL rendering. | |
| * | |
| * @fileoverview Data-Driven Styling System for POLARIS plugin |
src/plugins/polaris/styling.ts
Outdated
Comment on lines
2
to
8
| * Styling utilities for AequilibraE plugin | ||
| * | ||
| * This module provides functions for building visual styles from data. | ||
| * It handles color encoding, size mapping, filtering, and the creation | ||
| * of typed arrays optimized for WebGL rendering. | ||
| * | ||
| * @fileoverview Data-Driven Styling System for AequilibraE |
There was a problem hiding this comment.
The comment header incorrectly states "Styling utilities for AequilibraE plugin" when this file is for the POLARIS plugin. This should be updated to reflect the correct plugin name.
Suggested change
| * Styling utilities for AequilibraE plugin | |
| * | |
| * This module provides functions for building visual styles from data. | |
| * It handles color encoding, size mapping, filtering, and the creation | |
| * of typed arrays optimized for WebGL rendering. | |
| * | |
| * @fileoverview Data-Driven Styling System for AequilibraE | |
| * Styling utilities for POLARIS plugin | |
| * | |
| * This module provides functions for building visual styles from data. | |
| * It handles color encoding, size mapping, filtering, and the creation | |
| * of typed arrays optimized for WebGL rendering. | |
| * | |
| * @fileoverview Data-Driven Styling System for POLARIS |
| */ | ||
|
|
||
| import HTTPFileSystem from '../../js/HTTPFileSystem' | ||
| import { FileSystemConfig, DirectoryEntry } from '@/Globals' |
There was a problem hiding this comment.
Unused import DirectoryEntry.
Suggested change
| import { FileSystemConfig, DirectoryEntry } from '@/Globals' | |
| import { FileSystemConfig } from '@/Globals' |
src/plugins/polaris/styling.ts
Outdated
| */ | ||
|
|
||
| import * as cartoColors from 'cartocolor' | ||
| import { RGBA, RGB, ColorStyle, NumericStyle, LayerStyle, BuildArgs, BuildResult } from './types' |
There was a problem hiding this comment.
Unused import NumericStyle.
Suggested change
| import { RGBA, RGB, ColorStyle, NumericStyle, LayerStyle, BuildArgs, BuildResult } from './types' | |
| import { RGBA, RGB, ColorStyle, LayerStyle, BuildArgs, BuildResult } from './types' |
src/plugins/polaris/styling.ts
Outdated
| stride: number, | ||
| offset: number | ||
| ) => { | ||
| const nums = values.filter((v): v is number => v !== null) |
There was a problem hiding this comment.
Unused variable nums.
Suggested change
| const nums = values.filter((v): v is number => v !== null) |
src/plugins/polaris/usePolaris.ts
Outdated
| schemaName: string | ||
| ): Promise<void> { | ||
| // Create a temporary database file in memory for the attached DB | ||
| const tempDb = await spl.db(arrayBuffer) |
There was a problem hiding this comment.
Unused variable tempDb.
Suggested change
| const tempDb = await spl.db(arrayBuffer) | |
| await spl.db(arrayBuffer) |
| } | ||
|
|
||
| // Apply per-layer styles | ||
| for (const [layerName, bucket] of buckets.entries()) { |
There was a problem hiding this comment.
Unused variable layerName.
Suggested change
| for (const [layerName, bucket] of buckets.entries()) { | |
| for (const bucket of buckets.values()) { |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.