Add AequilibraE support #1
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 23 out of 27 changed files in this pull request and generated 25 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| font-size: 1.4rem; | ||
| height: 5rem; | ||
| font-size: 2.5rem; | ||
| // height: 3.5rem; |
There was a problem hiding this comment.
The commented-out height property on line 318 (// height: 3.5rem;) should either be removed or uncommented if it's needed. Leaving commented code creates maintenance confusion.
| // height: 3.5rem; |
src/plugins/sqlite-map/styling.ts
Outdated
| const buildColorEncoder = ( | ||
| values: any[], | ||
| style: any, | ||
| dataRange: [number, number] | null = null | ||
| ) => { | ||
| if (dataRange) { | ||
| values = values.map(v => { | ||
| const num = toNumber(v) | ||
| if (num === null) return null | ||
| return Math.max(dataRange[0], Math.min(dataRange[1], num)) | ||
| }) | ||
| } | ||
|
|
||
| const nums = values.map(toNumber).filter((v): v is number => v !== null) | ||
| const s = style || {} | ||
| const [min, max] = s.range ? s.range : [safeMin(nums), safeMax(nums)] | ||
|
|
||
| const paletteName = s.palette || 'YlGn' | ||
| const numColors = s.numColors || 7 | ||
| const colors = getPaletteColors(paletteName, numColors).map((h: string) => hexToRgba(h, 1)) | ||
|
|
||
| const scale = max === min ? 0 : (numColors - 1) / (max - min) | ||
|
|
||
| return (value: any) => { | ||
| const num = toNumber(value) ?? min | ||
| const idx = Math.round((num - min) * scale) | ||
| return colors[Math.max(0, Math.min(numColors - 1, idx))] | ||
| } | ||
| } |
There was a problem hiding this comment.
Missing input validation: the function buildColorEncoder doesn't validate that the palette name exists in cartoColors before accessing it. If an invalid palette name is provided, getPaletteColors will return an array of gray colors, which may not be the desired behavior. Consider adding validation or a more informative error message.
| import { | ||
| resolvePath, | ||
| resolvePaths, | ||
| getUsedColumns, | ||
| getNeededJoinColumn, | ||
| createJoinCacheKey, | ||
| hasGeometryColumn, | ||
| } from './utils' |
There was a problem hiding this comment.
Unused import getUsedColumns.
| // Create a cache key for this specific join query (for logging only) | ||
| const cacheKey = createJoinCacheKey( | ||
| joinConfig.database, | ||
| joinConfig.table, | ||
| neededColumn, | ||
| joinConfig.filter | ||
| ) | ||
|
|
There was a problem hiding this comment.
Unused variable cacheKey.
| // Create a cache key for this specific join query (for logging only) | |
| const cacheKey = createJoinCacheKey( | |
| joinConfig.database, | |
| joinConfig.table, | |
| neededColumn, | |
| joinConfig.filter | |
| ) |
| if (extraDb) { | ||
| // Centralized function will handle its own caching | ||
| joinedData = await getCachedJoinData(extraDb, joinConfig, neededColumn) | ||
| const colInfo = neededColumn ? ` (column: ${neededColumn})` : '' |
There was a problem hiding this comment.
Unused variable colInfo.
| const colInfo = neededColumn ? ` (column: ${neededColumn})` : '' |
Co-authored-by: Copilot <[email protected]>
…t clearAllCaches alias
…ew and finalize overlay on destroy
|
Latest commit partially merges #3, we don't want every change so doing merge manually. Plan going forward is
|
* Extend tile.vue to support hard-coded key-value pairs, sqlite queries for said values, sqlite queries for entire table * Full SQL support, either individual queries or a full table * Add usage comment * Colour palette-ing, defaults to original pastel palette * Apply suggestions from review
This PR adds AequilibraE support to SimWrapper. This involves,
src/plugins/aequilibrae/...src/plugins/pluginRegistry.tssrc/dash-panels/aequilibrae.vue(and_allPanels.ts)HTTPFileSystem.tsto add support for S3 bucketsIn my testing I've modified a few other scripts (Splash, deploy scripts, etc) but we don't want to suggest merging these back to the original SimWrapper project, so I will revert. Additionally, current work needs a good refactor, particularly