Skip to content

fix: change tinyvue to peerdependencies#573

Merged
hexqi merged 1 commit intoopentiny:refactor/developfrom
chilingling:fix/tiny-engine-peer-deps
Jun 15, 2024
Merged

fix: change tinyvue to peerdependencies#573
hexqi merged 1 commit intoopentiny:refactor/developfrom
chilingling:fix/tiny-engine-peer-deps

Conversation

@chilingling
Copy link
Member

@chilingling chilingling commented Jun 12, 2024

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Background and solution

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Chores
    • Updated dependency management to use peer dependencies for better compatibility.
    • Updated the vue version to support any patch releases in the 3.4.x range.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 12, 2024

Walkthrough

The changes in packages/design-core/package.json involve updating dependency management. Specific versions of several dependencies related to @opentiny/vue have been removed and replaced with peer dependency constraints. Additionally, the vue version has been updated from 3.4.23 to ^3.4.23, allowing for more flexibility in version compatibility.

Changes

File Change Summary
packages/design-core/package.json Removed specific versions for @opentiny/vue, @opentiny/vue-icon, @opentiny/vue-design-smb, @opentiny/vue-renderless, and @opentiny/vue-theme. Updated vue version to ^3.4.23. Added peer dependency constraints for the aforementioned packages.

Poem

In the garden of code, dependencies bloom,
A shift in the breeze, new versions loom.
Peer constraints now take the stage,
Flexibility reigns, a wiser age.
Vue's updated, to keep us in tune,
Our design core dances, beneath the tech moon.
🌸✨🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4e6064e and a4e21ab.

Files selected for processing (1)
  • packages/design-core/package.json (3 hunks)
Additional comments not posted (1)
packages/design-core/package.json (1)

122-127: The changes to move @opentiny/vue and related packages to peerDependencies with relaxed version constraints are appropriate for a library, enhancing flexibility for consumers.

Verification successful

The changes to move @opentiny/vue and related packages to peerDependencies with relaxed version constraints are appropriate for a library, enhancing flexibility for consumers. The verification script output shows that the updated version constraints have been reflected in the dependent projects without any breaking changes.

  • packages/design-core/package.json: Lines 122-127
Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify if the relaxed version constraints in peerDependencies affect any dependent projects negatively.

# Test: Search for the usage of these dependencies in dependent projects. Expect: No breaking changes due to version updates.
rg --type json $'@opentiny/vue' --files-with-matches | xargs cat | jq '.dependencies, .peerDependencies'

Length of output: 17070

@hexqi hexqi merged commit d5eaa6d into opentiny:refactor/develop Jun 15, 2024
yy-wow pushed a commit to yy-wow/tiny-engine that referenced this pull request Oct 10, 2024
@coderabbitai coderabbitai bot mentioned this pull request Jan 22, 2025
14 tasks
@chilingling chilingling deleted the fix/tiny-engine-peer-deps branch February 27, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants