USHIFT-367: apply rebase.sh to service-ca manifests#926
Conversation
Signed-off-by: Frank A. Zdarsky <fzdarsky@redhat.com>
openshift-ci
bot
added
the
approved
| name: signing-key | ||
| - mountPath: /var/run/configmaps/signing-cabundle | ||
| name: signing-cabundle | ||
| - name: service-ca-controller |
There was a problem hiding this comment.
this whitespace is not present in https://github.com/openshift/service-ca-operator/blob/master/bindata/v4.0.0/controller/deployment.yaml
There was a problem hiding this comment.
The whitespace change is the result from yq's reformatting.
| nodeSelector: | ||
| node-role.kubernetes.io/master: "" |
There was a problem hiding this comment.
It's unlikely that this was commented out in our code, you may want to figure out why this was here.
There was a problem hiding this comment.
We originally didn't have node roles set; this was fixed in #869 only recently; we probably missed removing the comment.
| operator: "Exists" | ||
| effect: "NoExecute" | ||
| tolerationSeconds: 120 | ||
| - key: node-role.kubernetes.io/master |
There was a problem hiding this comment.
again - these whitespaces don't appear in the orig
There was a problem hiding this comment.
The whitespace change is the result from yq's reformatting.
fzdarsky
changed the title
fzdarsky
changed the title
|
/retest |
|
@fzdarsky: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Is "the latest rebase automation" the version in the repo now, or in another PR? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, fzdarsky The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
Updates the service-ca manifests using the latest rebase.sh automation.
Most changes are completely neutral and result from the adoption of yq, e.g. reordering of fields resulting from yq appending added fields at the end rather than ordering them in alphabetically or different indentation. A few changes drop comments or labels that are no longer applied by the respective operator.
Signed-off-by: Frank A. Zdarsky fzdarsky@redhat.com
Partially addresses USHIFT-367