Set node-role.kubernetes.io based on MicroShift roles#869
Set node-role.kubernetes.io based on MicroShift roles#869openshift-merge-robot merged 1 commit intoopenshift:mainfrom
Conversation
|
/assign @fzdarsky |
Let's go for the same labels that are present in OpenShift. @dhellmann |
|
Yes, let's be consistent with standalone OpenShift. |
|
/kind bug |
|
Added |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, oglok, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pmtk: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Closes USHIFT-28 |
Which issue(s) this PR addresses:
Closes #661 USHIFT-28
Desc
Adds node labeling based on MicroShift roles. There's a slight difference between MicroShift's and kubelet's roles: control-plane vs controlplane, worker vs node