Skip to content

USHIFT-6319: add uncore-cache e2e test kubelet config on Microshift#5765

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
eslutsky:local-cache-test
Nov 29, 2025
Merged

USHIFT-6319: add uncore-cache e2e test kubelet config on Microshift#5765
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
eslutsky:local-cache-test

Conversation

@eslutsky
Copy link
Contributor

@eslutsky eslutsky commented Nov 19, 2025 •
edited
Loading

this feature dependent on:

  1. USHIFT-6178 Enable Custom FeatureGates #5723 , which will allow enabling optional feature gates
  2. kubelet configuration that will enable the cpuManager policy in kubelet.

configuration example:

api:
  featureGates:
    customNoUpgrade:
      enabled: CPUManagerPolicyBetaOptions
kubelet:
  reservedSystemCPUs: "0" 
  cpuManagerPolicy: static
  cpuManagerPolicyOptions:
    prefer-align-cpus-by-uncorecache: "true"

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2025
@openshift-ci openshift-ci bot requested review from copejon and pmtk November 19, 2025 13:39
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2025
@eslutsky eslutsky force-pushed the local-cache-test branch 3 times, most recently from a077660 to 41c2261 Compare November 19, 2025 16:48
@eslutsky eslutsky changed the title WIP: enable CPU Manager Cache Policy enable uncore-cache kubelet config on Microshift Nov 19, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2025
@eslutsky eslutsky changed the title enable uncore-cache kubelet config on Microshift WIP: enable uncore-cache kubelet config on Microshift Nov 19, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2025
@eslutsky eslutsky changed the title WIP: enable uncore-cache kubelet config on Microshift USHIFT-6318: enable uncore-cache kubelet config on Microshift Nov 19, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2025 •
edited by openshift-ci bot
Loading

@eslutsky: This pull request references USHIFT-6318 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

Details

In response to this:

this feature dependent on:

  1. USHIFT-6178 Enable Custom FeatureGates #5723 , which will allow enabling optional feature gates
  2. kubelet configuration that will enable the cpuManager policy in kubelet.

configuration example:

featureGates:
 customNoUpgrade:
   enabled: CPUManagerPolicyBetaOptions
kubelet:
 reservedSystemCPUs: "0" 
 cpuManagerPolicy: static
 cpuManagerPolicyOptions:
   prefer-align-cpus-by-uncorecache: "true"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pacevedom
Copy link
Contributor

pacevedom commented Nov 20, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2025
@pacevedom pacevedom mentioned this pull request Nov 20, 2025
Closed
@eslutsky eslutsky force-pushed the local-cache-test branch 6 times, most recently from 6ce0c79 to 7fdcf89 Compare November 24, 2025 10:26
@eslutsky eslutsky changed the title USHIFT-6318: enable uncore-cache kubelet config on Microshift USHIFT-6319: add uncore-cache e2e test kubelet config on Microshift Nov 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 24, 2025 •
edited by openshift-ci bot
Loading

@eslutsky: This pull request references USHIFT-6319 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

Details

In response to this:

this feature dependent on:

  1. USHIFT-6178 Enable Custom FeatureGates #5723 , which will allow enabling optional feature gates
  2. kubelet configuration that will enable the cpuManager policy in kubelet.

configuration example:

featureGates:
 customNoUpgrade:
   enabled: CPUManagerPolicyBetaOptions
kubelet:
 reservedSystemCPUs: "0" 
 cpuManagerPolicy: static
 cpuManagerPolicyOptions:
   prefer-align-cpus-by-uncorecache: "true"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pacevedom
pacevedom reviewed Nov 24, 2025
View reviewed changes
@eslutsky eslutsky force-pushed the local-cache-test branch 2 times, most recently from d5fa93a to 1d5e7e3 Compare November 25, 2025 10:02
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 25, 2025 •
edited by openshift-ci bot
Loading

@eslutsky: This pull request references USHIFT-6319 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

Details

In response to this:

this feature dependent on:

  1. USHIFT-6178 Enable Custom FeatureGates #5723 , which will allow enabling optional feature gates
  2. kubelet configuration that will enable the cpuManager policy in kubelet.

configuration example:

api:
 featureGates:
   customNoUpgrade:
     enabled: CPUManagerPolicyBetaOptions
kubelet:
 reservedSystemCPUs: "0" 
 cpuManagerPolicy: static
 cpuManagerPolicyOptions:
   prefer-align-cpus-by-uncorecache: "true"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2025
@eslutsky
Copy link
Contributor Author

eslutsky commented Nov 26, 2025

/retest-required

pacevedom
pacevedom reviewed Nov 27, 2025
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2025
@pacevedom
Copy link
Contributor

pacevedom commented Nov 27, 2025

/hold

agullon
agullon reviewed Nov 27, 2025
View reviewed changes
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2025
@eslutsky
added RF test for uncore cache
e899c69 
Signed-off-by: Evgeny Slutsky <eslutsky@redhat.com>
@eslutsky eslutsky requested a review from agullon November 28, 2025 10:45
@agullon
Copy link
Contributor

agullon commented Nov 28, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon, eslutsky, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [agullon,eslutsky,pacevedom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agullon
Copy link
Contributor

agullon commented Nov 28, 2025

/test e2e-aws-tests-bootc-release e2e-aws-tests-bootc-release-arm

@agullon
Copy link
Contributor

agullon commented Nov 28, 2025

/retest

@eslutsky
Copy link
Contributor Author

eslutsky commented Nov 28, 2025

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 28, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 28, 2025

@eslutsky: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agullon
Copy link
Contributor

agullon commented Nov 28, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 28, 2025

/retest-required

Remaining retests: 0 against base HEAD 3bd053f and 2 for PR HEAD e899c69 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 28, 2025

/retest-required

Remaining retests: 0 against base HEAD 05b8d3c and 1 for PR HEAD e899c69 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2025 •
edited
Loading

@eslutsky: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-full-conformance-serial-rhel-eus 0028927 link true /test ocp-full-conformance-serial-rhel-eus
ci/prow/ocp-full-conformance-rhel-eus 0028927 link true /test ocp-full-conformance-rhel-eus

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ggiguash
Copy link
Contributor

ggiguash commented Nov 29, 2025

The CertManager failure is not related to the PR fixes. Overriding to save on CI cycles.
/override ci/prow/e2e-aws-tests-release

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2025

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/e2e-aws-tests-release

Details

In response to this:

The CertManager failure is not related to the PR fixes. Overriding to save on CI cycles.
/override ci/prow/e2e-aws-tests-release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit d71f8ac into openshift:main Nov 29, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@copejon copejon Awaiting requested review from copejon

@pmtk pmtk Awaiting requested review from pmtk

@agullon agullon Awaiting requested review from agullon

1 more reviewer

@pacevedom pacevedom pacevedom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@agullon agullon

@pacevedom pacevedom

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@eslutsky @openshift-ci-robot @pacevedom @agullon @ggiguash @openshift-merge-robot