Skip to content

[release-4.19] USHIFT-6212: Remove topolvm code from MicroShift downstream repo#5591

Merged
openshift-merge-bot[bot] merged 3 commits intoopenshift:release-4.19from
ggiguash:remove-topolvm-code-419
Oct 11, 2025
Merged

[release-4.19] USHIFT-6212: Remove topolvm code from MicroShift downstream repo#5591
openshift-merge-bot[bot] merged 3 commits intoopenshift:release-4.19from
ggiguash:remove-topolvm-code-419

Conversation

@ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Oct 9, 2025

Manual cherrypick of #5589

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2025

@ggiguash: This pull request references USHIFT-6212 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.z" version, but no target version was set.

Details

In response to this:

Manual cherrypick of #5589

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jogeo and vanhalenar October 9, 2025 10:15
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2025
@ggiguash
Copy link
Contributor Author

ggiguash commented Oct 9, 2025

/test test-rpm

@ggiguash
Copy link
Contributor Author

/retest-required

@pmtk
Copy link
Member

pmtk commented Oct 10, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc-periodic
/test e2e-aws-tests-bootc-periodic-arm

@ggiguash
Copy link
Contributor Author

/override prow/e2e-aws-tests-bootc-periodic
/override ci/prow/e2e-aws-tests-bootc-periodic-arm

The test failures are not related to the change. Overriding to save on the CI cycles.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2025

@ggiguash: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • prow/e2e-aws-tests-bootc-periodic

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-aws-tests
  • ci/prow/e2e-aws-tests-arm
  • ci/prow/e2e-aws-tests-bootc
  • ci/prow/e2e-aws-tests-bootc-arm
  • ci/prow/e2e-aws-tests-bootc-periodic
  • ci/prow/e2e-aws-tests-bootc-periodic-arm
  • ci/prow/e2e-aws-tests-periodic
  • ci/prow/e2e-aws-tests-periodic-arm
  • ci/prow/images
  • ci/prow/ocp-full-conformance-rhel-eus
  • ci/prow/ocp-full-conformance-serial-rhel-eus
  • ci/prow/security
  • ci/prow/test-rebase
  • ci/prow/test-rpm
  • ci/prow/test-unit
  • ci/prow/verify
  • pull-ci-openshift-microshift-main-e2e-aws-tests
  • pull-ci-openshift-microshift-main-e2e-aws-tests-arm
  • pull-ci-openshift-microshift-main-e2e-aws-tests-bootc
  • pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-arm
  • pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic
  • pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic-arm
  • pull-ci-openshift-microshift-main-e2e-aws-tests-periodic
  • pull-ci-openshift-microshift-main-e2e-aws-tests-periodic-arm
  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-ocp-full-conformance-rhel-eus
  • pull-ci-openshift-microshift-main-ocp-full-conformance-serial-rhel-eus
  • pull-ci-openshift-microshift-main-security
  • pull-ci-openshift-microshift-main-test-rebase
  • pull-ci-openshift-microshift-main-test-rpm
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override prow/e2e-aws-tests-bootc-periodic
/override ci/prow/e2e-aws-tests-bootc-periodic-arm

The test failures are not related to the change. Overriding to save on the CI cycles.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ggiguash
Copy link
Contributor Author

/label backport-risk-assessed
/label jira/valid-bug
/verified by ci

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 11, 2025
@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 11, 2025
@openshift-ci-robot
Copy link

@ggiguash: This PR has been marked as verified by ci.

Details

In response to this:

/label backport-risk-assessed
/label jira/valid-bug
/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor Author

/override ci/prow/e2e-aws-tests-bootc-periodic

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2025

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/e2e-aws-tests-bootc-periodic

Details

In response to this:

/override ci/prow/e2e-aws-tests-bootc-periodic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ggiguash
Copy link
Contributor Author

/override ci/prow/e2e-aws-tests-bootc-periodic-arm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2025

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/e2e-aws-tests-bootc-periodic-arm

Details

In response to this:

/override ci/prow/e2e-aws-tests-bootc-periodic-arm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2025

@ggiguash: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-tests-bootc-periodic 3255dd2 link true /test e2e-aws-tests-bootc-periodic
ci/prow/e2e-aws-tests-bootc-periodic-arm 3255dd2 link true /test e2e-aws-tests-bootc-periodic-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 63d73c0 into openshift:release-4.19 Oct 11, 2025
17 checks passed
@ggiguash ggiguash deleted the remove-topolvm-code-419 branch October 14, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants