Skip to content

USHIFT-6212: Remove topolvm code from MicroShift downstream repo#5589

Merged
openshift-merge-bot[bot] merged 3 commits intoopenshift:mainfrom
ggiguash:remove-topolvm-code
Oct 10, 2025
Merged

USHIFT-6212: Remove topolvm code from MicroShift downstream repo#5589
openshift-merge-bot[bot] merged 3 commits intoopenshift:mainfrom
ggiguash:remove-topolvm-code

Conversation

@ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Oct 9, 2025

See the related microshift-io/microshift#59

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2025

@ggiguash: This pull request references USHIFT-6212 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

See the related microshift-io/microshift#59

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor Author

ggiguash commented Oct 9, 2025

/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 9, 2025
@openshift-ci-robot
Copy link

@ggiguash: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pmtk
Copy link
Member

pmtk commented Oct 10, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 170e2dd and 2 for PR HEAD 93f01b2 in total

@eslutsky
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eslutsky, ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [eslutsky,ggiguash,pmtk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eslutsky
Copy link
Contributor

/override ci/prow/e2e-aws-tests-bootc-periodic
/override ci/prow/e2e-aws-tests-bootc-periodic-arm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2025

@eslutsky: Overrode contexts on behalf of eslutsky: ci/prow/e2e-aws-tests-bootc-periodic, ci/prow/e2e-aws-tests-bootc-periodic-arm

Details

In response to this:

/override ci/prow/e2e-aws-tests-bootc-periodic
/override ci/prow/e2e-aws-tests-bootc-periodic-arm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2025

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit cb49b17 into openshift:main Oct 10, 2025
17 checks passed
@ggiguash ggiguash deleted the remove-topolvm-code branch October 14, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants