update all-in-one systemd, use podman generated ExecStart|Stop

[sallyom]

Signed-off-by: Sally O'Malley somalley@redhat.com

Which issue(s) this PR addresses:
follow-up for #276

This PR updates the systemd ExecStart|Stop commands to be in line with podman generate systemd --new --name ctrID. The --new flag creates and uses a --cid-file & --pid-file to ensure container is removed upon stop so that when service is enabled and starts with machine start, the podman cmd will not fail due to container with name microshift-aio already exists

Note: The unit file is generated with Podman 3.3.1 and adds

Type=notify
NotifyAccess=all

also adds the --sdnotify=conmon --cgroups=no-conmon flags to the podman run cmd.

older versions of podman generate this:

Type=forking

[sallyom]

/assign @fzdarsky

I confirmed with VM restart that there are no issues with service startup. I also asked in slack w/ container-engines people if the Type=notify is only with the most recent podman version. Last time (last week) I used podman generate systemd it produces a unit file with Type=forking 🤷
EDIT:
This is indeed new, podman recently updated the type to notify because notify supports more use cases. This will not cause an issue if machine has older version of podman, I checked back to podman 2.2.1 at least.

[rootfs]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rootfs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [rootfs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment