microshift-containerized as a systemd service using host's cri-o#308
microshift-containerized as a systemd service using host's cri-o#308mangelajo merged 2 commits intoopenshift:mainfrom
Conversation
e118252 to
c595f5b
Compare
|
@husky-parul I have a PR to update the generated unit file, you'll want to update this PR too. Otherwise upon machine restart the service fails due to |
c595f5b to
2baebd9
Compare
2baebd9 to
8ed15bd
Compare
|
@sallyom ready for review |
Signed-off-by: Parul <parsingh@redhat.com>
Signed-off-by: Parul <parsingh@redhat.com>
|
/assign @fzdarsky |
|
lgtm |
|
@rootfs: GitHub didn't allow me to assign the following users: mangelajo. Note that only redhat-et members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
@mangelajo: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is still complaining on me. ':D |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mangelajo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Parul parsingh@redhat.com
Which issue(s) this PR addresses:
This PR partially resolves #276
microshift-containerizedis runningmicroshiftas a systemd service usingpodmanand host'scri-oThis PR
microshift-containerizedmicroshift-containerized