Skip to content

microshift-containerized as a systemd service using host's cri-o#308

Merged
mangelajo merged 2 commits intoopenshift:mainfrom
husky-parul:crio-host
Oct 19, 2021
Merged

microshift-containerized as a systemd service using host's cri-o#308
mangelajo merged 2 commits intoopenshift:mainfrom
husky-parul:crio-host

Conversation

@husky-parul
Copy link
Copy Markdown
Contributor

@husky-parul husky-parul commented Sep 24, 2021

Signed-off-by: Parul parsingh@redhat.com

Which issue(s) this PR addresses:
This PR partially resolves #276
microshift-containerized is running microshift as a systemd service using podman and host's cri-o

This PR

  • systemd unit file for running microshift-containerized
  • mounts host's cri-o as a volume on microshift-containerized

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2021
@openshift-ci openshift-ci bot requested review from fzdarsky and sallyom September 24, 2021 13:24
@husky-parul husky-parul force-pushed the crio-host branch 6 times, most recently from e118252 to c595f5b Compare September 28, 2021 13:36
@husky-parul husky-parul changed the title [WIP] mount host cri-o on microshift-aio [WIP] microshift-containerized as a systemd service using host's cri-o Sep 28, 2021
@husky-parul husky-parul changed the title [WIP] microshift-containerized as a systemd service using host's cri-o microshift-containerized as a systemd service using host's cri-o Sep 28, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 28, 2021
@sallyom
Copy link
Copy Markdown
Contributor

sallyom commented Sep 28, 2021

@husky-parul I have a PR to update the generated unit file, you'll want to update this PR too. Otherwise upon machine restart the service fails due to container already exists with that name error. The --new flag was missing when we generated the unit file before.
Also, since podman generate systemd --new sets the ExecStart|Stop with the podman cmds, I modified the /usr/bin/microshift-script to only include the setsebool cmd, recording of the kubeconfig path, & conditional volume create and it should run with the ExecPreStart. Take a look!
#315

@husky-parul husky-parul changed the title microshift-containerized as a systemd service using host's cri-o [WIP]microshift-containerized as a systemd service using host's cri-o Sep 29, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2021
@husky-parul husky-parul changed the title [WIP]microshift-containerized as a systemd service using host's cri-o microshift-containerized as a systemd service using host's cri-o Sep 29, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2021
@husky-parul
Copy link
Copy Markdown
Contributor Author

@sallyom ready for review

Signed-off-by: Parul <parsingh@redhat.com>
Signed-off-by: Parul <parsingh@redhat.com>
@husky-parul
Copy link
Copy Markdown
Contributor Author

/assign @fzdarsky

@rootfs
Copy link
Copy Markdown
Member

rootfs commented Oct 6, 2021

lgtm
/assign @oglok @mangelajo

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Oct 6, 2021

@rootfs: GitHub didn't allow me to assign the following users: mangelajo.

Note that only redhat-et members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

lgtm
/assign @oglok @mangelajo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mangelajo
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Oct 19, 2021

@mangelajo: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mangelajo
Copy link
Copy Markdown
Contributor

@mangelajo: changing LGTM is restricted to collaborators

This is still complaining on me. ':D

@mangelajo
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Oct 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mangelajo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2021
@mangelajo mangelajo merged commit 6e28e6f into openshift:main Oct 19, 2021
@husky-parul husky-parul deleted the crio-host branch November 3, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add systemd units for production deployments on Podman

6 participants