[release-4.14] OCPBUGS-18773: Stop all MicroShift components when signaled to exit#2330
Conversation
By using cmd.Context(), KCM will use a context MicroShift passes down through all the components. When using context.Background() it won't ever stop, because it's never cancelled, and result in blocking ServiceManager which waits for all components to stop and make MicroShift use its whole internal gracefulShutdownTimer.
shutdown-delay-duration tells KAS how long to serve after receiving a stop signal. Its value is provided to time.Sleep(), so it's used in full; there is not short-circuit mechanism that would let KAS exit earlier.
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-18548 has been cloned as Jira Issue OCPBUGS-18773. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-18773, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
/retest |
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
/retest |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@pmtk: This pull request references Jira Issue OCPBUGS-18773, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-18773: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-18773 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
This is an automated cherry-pick of #2319
/assign pmtk