OCPBUGS-18548: Stop all MicroShift components when signaled to exit

[pmtk]

make KCM use context we give to command

By using cmd.Context(), KCM will use a context MicroShift passes down through all the components.

When using context.Background() it won't ever stop, because it's never cancelled, and result in blocking ServiceManager which waits for all components to stop and make MicroShift use its whole internal gracefulShutdownTimer.

---

override KAS' shutdown-delay-duration to 5s (from 70s)

shutdown-delay-duration tells KAS how long to serve after receiving a stop signal.

Its value is provided to time.Sleep(), so it's used in full; there is not short-circuit mechanism that would let KAS exit earlier.

Default value of 70s is set in assets/controllers/kube-apiserver/defaultconfig.yaml

[openshift-ci-robot]

@pmtk: This pull request references Jira Issue OCPBUGS-18548, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[pmtk]

/test all

[pmtk]

/jira refresh

[openshift-ci-robot]

@pmtk: This pull request references Jira Issue OCPBUGS-18548, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@pmtk: This pull request references Jira Issue OCPBUGS-18548, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

Details

In response to this:

make KCM use context we give to command

By using cmd.Context(), KCM will use a context MicroShift passes down through all the components.

When using context.Background() it won't ever stop, because it's never cancelled, and result in blocking ServiceManager which waits for all components to stop and make MicroShift use its whole internal gracefulShutdownTimer.

---

override KAS' shutdown-delay-duration to 5s

shutdown-delay-duration tells KAS how long to serve after receiving a stop signal.

Its value is provided to time.Sleep(), so it's used in full; there is not short-circuit mechanism that would let KAS exit earlier.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@pmtk: This pull request references Jira Issue OCPBUGS-18548, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

make KCM use context we give to command

By using cmd.Context(), KCM will use a context MicroShift passes down through all the components.

When using context.Background() it won't ever stop, because it's never cancelled, and result in blocking ServiceManager which waits for all components to stop and make MicroShift use its whole internal gracefulShutdownTimer.

---

override KAS' shutdown-delay-duration to 5s (from 70s)

shutdown-delay-duration tells KAS how long to serve after receiving a stop signal.

Its value is provided to time.Sleep(), so it's used in full; there is not short-circuit mechanism that would let KAS exit earlier.

Default value of 70s is set in assets/controllers/kube-apiserver/defaultconfig.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[eggfoobar]

/lgtm

nice find!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [eggfoobar,pmtk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@pmtk: Jira Issue OCPBUGS-18548: All pull requests linked via external trackers have merged:

• openshift/microshift#2319

Jira Issue OCPBUGS-18548 has been moved to the MODIFIED state.

Details

In response to this:

make KCM use context we give to command

By using cmd.Context(), KCM will use a context MicroShift passes down through all the components.

When using context.Background() it won't ever stop, because it's never cancelled, and result in blocking ServiceManager which waits for all components to stop and make MicroShift use its whole internal gracefulShutdownTimer.

---

override KAS' shutdown-delay-duration to 5s (from 70s)

shutdown-delay-duration tells KAS how long to serve after receiving a stop signal.

Its value is provided to time.Sleep(), so it's used in full; there is not short-circuit mechanism that would let KAS exit earlier.

Default value of 70s is set in assets/controllers/kube-apiserver/defaultconfig.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pmtk]

/cherrypick release-4.14

[openshift-cherrypick-robot]

@pmtk: new pull request created: #2330

Details

In response to this:

/cherrypick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.