Skip to content

fixes binary checksum validation and binary naming in releases #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oglok merged 1 commit into from
Aug 17, 2021
Merged

fixes binary checksum validation and binary naming in releases #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,15 +133,15 @@ get_kubectl() {
# Download and install microshift
get_microshift() {
if [ $ARCH = "x86_64" ]; then
curl -L https://github.com/redhat-et/microshift/releases/download/$VERSION/microshift-linux-amd64 -o microshift
curl -L https://github.com/redhat-et/microshift/releases/download/$VERSION/release.sha256 -o release.sha256
curl -LO https://github.com/redhat-et/microshift/releases/download/$VERSION/microshift-linux-amd64
curl -LO https://github.com/redhat-et/microshift/releases/download/$VERSION/release.sha256 -o release.sha256
fi

SHA=$(sha256sum microshift | awk '{print $1}')
if [[ $SHA != $(cat release.sha256 | awk '{print $1}') ]]; then echo "SHA256 checksum failed" && exit 1; fi
SHA=$(sha256sum microshift-linux-amd64 | awk '{print $1}')
if [[ $SHA != $(grep "microshift-linux-amd64" release.sha256 | awk '{print $1}') ]]; then echo "SHA256 checksum failed" && exit 1; fi

sudo chmod +x microshift
sudo mv microshift /usr/local/bin/
sudo chmod +x microshift-linux-amd64
sudo mv microshift-linux-amd64 /usr/local/bin/microshift

apply_selinux_policy

Expand Down
3 changes: 1 addition & 2 deletions scripts/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,7 @@ prep_stage_area() {
extract_release_image_binary() {
local tag="$1"
local dest="$2"
arch_ver=${tag#*:}
local out_bin="$dest"/microshift-"$arch_ver"
local out_bin="$dest"/microshift-"${tag#*"$VERSION-"}"
podman cp "$(podman create "$tag")":/usr/bin/microshift "$out_bin" >&2
echo "$out_bin"
}
Expand Down